Skip to content

For NTPsec, ignore error about statistics directory not existing#10502

Merged
saiarcot895 merged 1 commit intosonic-net:masterfrom
saiarcot895:ntp-ignore-stats-dir-missing
Oct 26, 2023
Merged

For NTPsec, ignore error about statistics directory not existing#10502
saiarcot895 merged 1 commit intosonic-net:masterfrom
saiarcot895:ntp-ignore-stats-dir-missing

Conversation

@saiarcot895
Copy link
Copy Markdown
Contributor

@saiarcot895 saiarcot895 commented Oct 26, 2023 •
edited
Loading

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

NTPsec by default wants to log statistics to a file (or at least check to see that the statistics directory exists, even if no logging is enabled). To match the behavior we had with NTP where no logging is enabled, don't configure the statistics directory for NTPsec, and ignore any errors about it not existing.

How did you do it?

How did you verify/test it?

Tested on Bookworm image by running generic_config_updater/test_aaa.py test suite. This suite was previously failing with loganalyzer errors from ntpd.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@saiarcot895
For NTPsec, ignore error about statistics directory not existing
e5ea582 
NTPsec by default wants to log statistics to a file (or at least check
to see that the statistics directory exists, even if no logging is
enabled). To match the behavior we had with NTP where no logging is
enabled, don't configure the statistics directory for NTPsec, and ignore
any errors about it not existing.

Signed-off-by: Saikrishna Arcot <[email protected]>
@saiarcot895 saiarcot895 marked this pull request as ready for review October 26, 2023 20:59
@saiarcot895 saiarcot895 merged commit 8aa3100 into sonic-net:master Oct 26, 2023
@saiarcot895 saiarcot895 deleted the ntp-ignore-stats-dir-missing branch October 26, 2023 22:44
@saiarcot895 saiarcot895 mentioned this pull request Oct 28, 2023
Closed
@nazariig nazariig mentioned this pull request Oct 15, 2025
Open
weiguo-nvidia added a commit to weiguo-nvidia/sonic-mgmt that referenced this pull request Nov 7, 2025
@weiguo-nvidia
Ignore known error log
13f95b1 
PR sonic-net#10502 already ignore the error log,
but the regex can not match this error log, fix it.

Change-Id: I2af0013631ffd1c9706f5bd8c48341132324ffaa
@weiguo-nvidia weiguo-nvidia mentioned this pull request Nov 7, 2025
Merged
11 tasks
wangxin pushed a commit that referenced this pull request Dec 16, 2025
@weiguo-nvidia
Update regex to ignore known error log (#21232)
ec3b88b 
PR #10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
@weiguo-nvidia @gshemesh2
Update regex to ignore known error log (sonic-net#21232)
5e946d2 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Guy Shemesh <[email protected]>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 18, 2025
@weiguo-nvidia @selldinesh
Update regex to ignore known error log (sonic-net#21232)
293f9f3 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: selldinesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@weiguo-nvidia @gshemesh2
Update regex to ignore known error log (sonic-net#21232)
7c08f58 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@weiguo-nvidia @gshemesh2
Update regex to ignore known error log (sonic-net#21232)
8856c6d 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Guy Shemesh <[email protected]>
vrajeshe pushed a commit to Akshath-17/sonic-mgmt that referenced this pull request Jan 4, 2026
@weiguo-nvidia @vrajeshe
Update regex to ignore known error log (sonic-net#21232)
f0cb971 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Venkata Gouri Rajesh Etla <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@weiguo-nvidia @venu-nexthop
Update regex to ignore known error log (sonic-net#21232)
3c74678 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
@weiguo-nvidia @yifan-nexthop
Update regex to ignore known error log (sonic-net#21232)
d1c2d7d 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: YiFan Wang <[email protected]>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 20, 2026
@weiguo-nvidia @mssonicbld
Update regex to ignore known error log (sonic-net#21232)
624b686 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied
@mssonicbld mssonicbld mentioned this pull request Jan 20, 2026
Merged
11 tasks
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
@weiguo-nvidia @PriyanshTratiya
Update regex to ignore known error log (sonic-net#21232)
89e0013 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Priyansh Tratiya <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@weiguo-nvidia @ytzur1
Update regex to ignore known error log (sonic-net#21232)
b0ae2e3 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
@weiguo-nvidia @abhishek-nexthop
Update regex to ignore known error log (sonic-net#21232)
82bcebf 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
@weiguo-nvidia @rraghav-cisco
Update regex to ignore known error log (sonic-net#21232)
58385ef 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Raghavendran Ramanathan <[email protected]>
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
@weiguo-nvidia @ztan-amd
Update regex to ignore known error log (sonic-net#21232)
0a11496 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Zhuohui Tan <[email protected]>
vmittal-msft pushed a commit that referenced this pull request Feb 23, 2026
@mssonicbld @weiguo-nvidia
Update regex to ignore known error log (#21232) (#22009)
bff775c 
PR #10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Co-authored-by: weguo-NV <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
@weiguo-nvidia @abhishek-nexthop
Update regex to ignore known error log (sonic-net#21232)
f48b11f 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied

Signed-off-by: Abhishek <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Mar 27, 2026
@weiguo-nvidia
Update regex to ignore known error log (sonic-net#21232)
15f587f 
PR sonic-net#10502 already ignore the error log, but the regex .* ERR ntpd.*: statistics directory .* does not exist or is unwriteable, error No such file or directory can not match this error log. So update the regex.

ERR ntpd[25710]: statistics directory /var/log/ntpsec/ does not exist or is unwriteable, error Permission denied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saiarcot895 @yxieca