[add-topo] Add support for specifying PTF docker image tag#1045
Merged
lguohan merged 1 commit intosonic-net:masterfrom Aug 2, 2019
wangxin:ptf-imagetag
Merged
[add-topo] Add support for specifying PTF docker image tag#1045lguohan merged 1 commit intosonic-net:masterfrom wangxin:ptf-imagetag
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:ptf-imagetag
Conversation
PTF docker container is pulled and created while add-topo. By default, the PTF docker image with "latest" tag is always pulled. This change added a variable for specifying PTF image tag while add-topo. The variable value can be specified via CLI option. If the variable value is not given, default "latest" value will be used. Signed-off-by: Xin Wang <[email protected]>
1 task
lguohan
approved these changes
Aug 1, 2019
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: This add params for the qos sai tests for t1-f2-d10u8 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? #### How did you do it? Generated with script and manually adjusted #### How did you verify/test it? Manually tested #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
PTF docker container is pulled and created while add-topo.
By default, the PTF container is always created from PTF image
with "latest" tag. This change added a variable for specifying PTF
image tag while add-topo. The variable value can be
specified via CLI option. If the variable value is not given,
default "latest" value will be used.
When this variable is specified, PTF container will be created
from PTF image with the specified tag.
For example:
./testbed-cli.sh add-topo <testbed_name>- vault -e ptf_imagetag=201811
By using this practice, we suggest to add different tags for different PTF image
versions in docker registry.
There is no need to merge this PR to 201811 branch. There is a dedicated PR for 201811 (#1046)
Type of change
Approach
How did you do it?
Added a variable ptf_imagetag in add_topo.yml.
When this variable is specified, PTF container will be created from PTF image with the specified tag.
How did you verify/test it?
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
Documentation