[action] [PR:10226] limit the modification of pg_num to only occur on the specific platform to fix testQosSaiHeadroomPoolWatermark failure#10377
Merged
mssonicbld merged 1 commit intosonic-net:202205from Oct 18, 2023
Conversation
7 tasks
Collaborator
Author
|
Original PR: #10226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
different input qos parameter for testQosSaiHeadroomPoolSize and
wrong qos paramreter for testQosSaiHeadroomPoolWatermark,
RCA:
for this case pgs_num value should be 4.
but here, its value is 46, and then it will test consume share buffer using 46 couple of parameters.
finally, caused test failure
the reason is that pg_num was increated in PR #8213 before ptf test.
How did you do it?
there is conditional statement to limit the modification of pg_num to only occur on the specific platform in similar test case "testQosSaiHeadroomPoolSize".
so, limit the modification of pg_num for testQosSaiHeadroomPoolWatermark as well
How did you verify/test it?
pass local test
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation