[warm-reboot] Preboot sad path automation for n lag members#1036
Merged
neethajohn merged 4 commits intosonic-net:masterfrom Aug 28, 2019
Merged
[warm-reboot] Preboot sad path automation for n lag members#1036neethajohn merged 4 commits intosonic-net:masterfrom
neethajohn merged 4 commits intosonic-net:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Suggest to introduce one more method which uses change_neigh_lag_state().
The new method could work with many interface and use existing method to change one interface
Contributor
There was a problem hiding this comment.
temp is not the best name in this case. I'd better use someting more meaningful
yxieca
reviewed
Jul 30, 2019
Collaborator
There was a problem hiding this comment.
It would be helpful to add an example of input string here for reference. Also the code has an implicit decision that only the last 2 values were used. You should add a comment to explain the choice.
Contributor
Author
There was a problem hiding this comment.
added more comments
3b3fd4e to
217478a
Compare
yxieca
approved these changes
Aug 15, 2019
Signed-off-by: Neetha John <nejo@microsoft.com>
217478a to
58bf1d6
Compare
yxieca
pushed a commit
that referenced
this pull request
Aug 29, 2019
* Preboot sad path automation for n lag members Signed-off-by: Neetha John <nejo@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Neetha John nejo@microsoft.com
Description of PR
Covers cases where a single lag member or all lag members can be brought down from the neighbor end or DUT end before warm-reboot
Test case as follows
Type of change
Approach
How did you do it?
*.py
How did you verify/test it?
Tested on T0 topology. Seeing some issues in the single lag member down case. Need investigation.