[Config Test] swss exit after remove port channel due to SAI not found L3 interface#1028
Merged
lguohan merged 1 commit intosonic-net:masterfrom Aug 15, 2019
Merged
Conversation
…d intf The timeline have the possibility be 1. Playbook remove IP from port channel intfOrch want to remove l3 intf, but neighOrch still have reference and the intfOrch will wait to next run 2. Playbook remove port channel portOrch remove this port and its l3 intf in SAI 3. neighOrch neighOrch finish the reference count decreament and then intfOrch remove l3 intf to SAI whcih was removed by step 2. Then the swss will excpetion
Contributor
|
thank you! |
yxieca
added
Included in 201811 branch
Request for 201811 branch 
and removed
Included in 201811 branch
labels
yxieca
pushed a commit
that referenced
this pull request
Aug 16, 2019
…d intf (#1028) When executing the config test case, it has the possibility to cause swss exit. It is due to the intfOrch may be slower than portOrch When the issue not happens, the timeline would be 1. Playbook remove IP from port channel intfOrch want to remove l3 intf, but neighOrch still have reference and the intfOrch will wait to next run 2. neighOrch decrease the reference count neighOrch finish the reference count decrement and then intfOrch remove l3 intf to SAI 3. Playbook remove port channel portOrch remove this port in SAI When the issue happens, the timeline would be 1. Playbook remove IP from port channel intfOrch want to remove l3 intf, but neighOrch still have reference and the intfOrch will wait to next run 2. Playbook remove port channel portOrch remove this port and its l3 intf in SAI 3. neighOrch decrease the reference count neighOrch finish the reference count decrement and then intfOrch remove l3 intf to SAI whcih was removed by step 2. Then the swss will exception
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Mar 23, 2026
…for extra entries added by generic patcher (sonic-net#1028) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: When patching the DUT to remove t0 peers, the test fails the DB comparison due to extra entries being added to APP_DB. These entries only get added when generic patcher in SONiC (`config apply-patch`) is used to remove t0 from the DUT. Ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] msft_202412 - [x] 202505 ### Approach #### What is the motivation for this PR? `configlet/test_add_rack.py` is failing. #### How did you do it? Adding extra entries to ignore. These entries seems to be harmless and not used. However it is not understood why it is being added by `config apply-patch`. Again, ideally this should be fixed in `config apply-patch` code. This PR is a workaround for the issue since the extra entries are harmless and does not get used. #### How did you verify/test it? Test no longer fails #### Any platform specific information? Broadcom platform is used for testing. #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
When executing the config test case, it has the possibility to cause swss exit. It is due to the intfOrch may be slower than portOrch
When the issue not happens, the timeline would be
Playbook remove IP from port channel
intfOrch want to remove l3 intf, but neighOrch still have reference and the intfOrch will wait to next run
neighOrch decrease the reference count
neighOrch finish the reference count decrement and then intfOrch remove l3 intf to SAI
Playbook remove port channel
portOrch remove this port in SAI
When the issue happens, the timeline would be
Playbook remove IP from port channel
intfOrch want to remove l3 intf, but neighOrch still have reference and the intfOrch will wait to next run
Playbook remove port channel
portOrch remove this port and its l3 intf in SAI
neighOrch decrease the reference count
neighOrch finish the reference count decrement and then intfOrch remove l3 intf to SAI whcih was removed by step 2. Then the swss will exception
Summary:
Fixes # (issue)
Type of change