[CRM] Wait more time for CRM stats to update#1027
Merged
prsunny merged 1 commit intosonic-net:masterfrom Jul 30, 2019
wangxin:crm-wait-pr
Merged
[CRM] Wait more time for CRM stats to update#1027prsunny merged 1 commit intosonic-net:masterfrom wangxin:crm-wait-pr
prsunny merged 1 commit intosonic-net:masterfrom
wangxin:crm-wait-pr
Conversation
CRM testing may fail because CRM stats was not updated yet while checking the counters. Main purpose of this change is to increase the time waiting for CRM update from 2 seconds to 4 seconds. Two other improvements: * Decrease the time waiting for CRM counters update from 300 seconds to 30 seconds. The 300 seconds waiting is unnecessary. * Use a single redis-cli command to get used and available counters rather than two commands. Signed-off-by: Xin Wang <[email protected]>
prsunny
approved these changes
Jul 30, 2019
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
CRM testing may fail because CRM stats was not updated yet
while checking the counters. Main purpose of this change is
to increase the time waiting for CRM update from 2 seconds
to 4 seconds.
Two other improvements made in this PR:
300 seconds to 30 seconds. The 300 seconds waiting is
unnecessary.
counters rather than two commands.
Type of change
Approach
How did you do it?
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
NA
Documentation