Use pytest option for swapping syncd in dscp remapping test#10074
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Sep 26, 2023
Merged
Use pytest option for swapping syncd in dscp remapping test#10074bingwang-ms merged 1 commit intosonic-net:masterfrom
bingwang-ms merged 1 commit intosonic-net:masterfrom
Conversation
For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
nhe-NV
approved these changes
Sep 22, 2023
bingwang-ms
approved these changes
Sep 26, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…t#10074) For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 1, 2024
…t#10074) For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Feb 1, 2024
…t#10074) For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
Collaborator
|
Cherry-pick PR to 202305: #11487 |
Collaborator
|
Cherry-pick PR to 202205: #11488 |
This was referenced Feb 1, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Feb 1, 2024
For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
mssonicbld
pushed a commit
that referenced
this pull request
Feb 1, 2024
For Nvidia, we use the RPC image instead of swapping syncd in the qos sai test. We need an option to control if the swap_syncd should be executed. Change-Id: Ideb8bd1054604d77bf26c5c44624f7d493d9eb41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
For Nvidia, we use the RPC image instead of swapping syncd in the qos sai tests. We need an option to control if the swap_syncd should be executed.
Type of change
Back port request
Approach
What is the motivation for this PR?
The pytest option "--qos_swap_syncd" is used in the regular qos sai test and we should also use it in the dscp remapping test.
The default value of this option is True, so this change won't affect existing test execution.
https://github.com/sonic-net/sonic-mgmt/blob/master/tests/conftest.py#L95-L96
How did you do it?
Only swap the syncd when "--qos_swap_syncd" is True.
How did you verify/test it?
Verified on dualtor testbed, no issues found.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation