[202205][advanced-reboot][dualtor] Update Loopback0 ping test: expect same count for sent and rcvd packets#10068
Merged
wangxin merged 1 commit intosonic-net:202205from Sep 28, 2023
Merged
Conversation
…unt for sent and rcvd packets (sonic-net#9599) Summary: Currently dual tor warmboot fails w/ control plane not ready for warmboot. This is because the test expects 2 responses for every ping packet sent to Loopback. This expectation is not correct after PR sonic-net#9089 is merged. Update the testcase to now only expect 1 icmp response for every icmp packet sent to Loopback0. Updated the test to remove the earlier expectation of removing the packets that were sent by icmp_responder. This essentially reverts part of older PR: sonic-net#6968 How did you verify/test it? Tested on a physical testbed and this test issue is not seen. The test is now able to see the responses of ping packets
wangxin
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raising PR for cherry-pick conflict:
225e257 [advanced-reboot][dualtor] Update Loopback0 ping test: expect same count for sent and rcvd packets (#9599)
sign-off: Jing Zhang zhangjing@microsoft.com