Skip to content

Fix for GCU DHCP_Realy failure for HEAD#10046

Merged
yejianquan merged 21 commits intosonic-net:masterfrom
ridahanif96:Dhcp_mode
Sep 21, 2023
Merged

Fix for GCU DHCP_Realy failure for HEAD#10046
yejianquan merged 21 commits intosonic-net:masterfrom
ridahanif96:Dhcp_mode

Conversation

@ridahanif96
Copy link
Copy Markdown
Contributor

@ridahanif96 ridahanif96 commented Sep 15, 2023

Description of PR

This PR is created to resolve issues in KVM test which are failing in advance utilities HEAD PR. KVM Elastic test are failing in generic_config_updater/test_dhcp_relay.py file due to missing mode attribute.

What is the motivation for this PR?

Modified GCU fixtures/duthost_utilities.py to make it compatible for HEAD PR . We have added "switchport mode command" in duthost_utilites to add mode trunk on Ethernet4 so that it will allow addition of vlan membership on ports.

@ridahanif96 ridahanif96 changed the title Dhcp mode Fix for GCU DHCP_Realy failure for HEAD Sep 16, 2023
@yejianquan yejianquan merged commit 7570839 into sonic-net:master Sep 21, 2023
Copy link
Copy Markdown
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
Description of PR
This PR is created to resolve issues in KVM test which are failing in advance utilities HEAD PR. KVM Elastic test are failing in generic_config_updater/test_dhcp_relay.py file due to missing mode attribute.

What is the motivation for this PR?
Modified GCU fixtures/duthost_utilities.py to make it compatible for HEAD PR . We have added "switchport mode command" in duthost_utilites to add mode trunk on Ethernet4 so that it will allow addition of vlan membership on ports.

co-authorized by: jianquanye@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants