[action] [PR:9987] Conditionally install env-python3 in setup-container.sh#10033
Merged
mssonicbld merged 1 commit intosonic-net:202012from Sep 15, 2023
Merged
Conversation
The sonic-mgmt docker image has been updated to globally install all the packages in env-python3. Now, in the global python3 environment, we have all the required packages for running tests. Then it is unnecessary to have the env-python3 virtual environment. Before "env-python3" is deprecated in sonic-mgmt docker image, we can skip creating "env-python3" in the setup-container.sh script which is used for setting up sonic-mgmt container for user different than "AzDevOps" to solve permission issues of mapped directory. This change added code to check if pytest is globally installed in python3 environment. If yes, then we can assume that all the env-python3 packages are also globally installed. Then we can skip creating env-python3 in setup-container.sh script. Signed-off-by: Xin Wang <xiwang5@microsoft.com>
6 tasks
Collaborator
Author
|
Original PR: #9987 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The sonic-mgmt docker image has been updated to globally install all the packages in env-python3. Now, in the global python3 environment, we have all the required packages for running tests. Then it is unnecessary to have the env-python3 virtual environment. Before "env-python3" is deprecated in sonic-mgmt docker image, we can skip creating "env-python3" in the setup-container.sh script which is used for setting up sonic-mgmt container for user different than "AzDevOps" to solve permission issues of mapped directory.
How did you do it?
This change added code to check if pytest is globally installed in python3 environment. If yes, then we can assume that all the env-python3 packages are also globally installed. Then we can skip creating env-python3 in setup-container.sh script.
How did you verify/test it?
Run setup-container.sh using old and new sonic-mgmt docker images.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation