-
Notifications
You must be signed in to change notification settings - Fork 1k
[crm, cacl] Refactoring of recover_acl_rule fixture causing failures in cacl and crm tests #9468
Copy link
Copy link
Closed
Description
Description
Two new errors observed when running cacl/test_cacl_function.py or crm/test_crm.py with the change in #9312 on modular systems:
KeyError: 'DATAACL'
and
AttributeError: 'SubRequest' object has no attribute 'param'
Steps to reproduce the issue:
For the KeyError: 'DATAACL' error:
- Run
cacl/test_cacl_function.pyorcrm/test_crm.pyon a modular system. - The refactored
recover_acl_rulefixture will be invoked which specifiesenum_rand_one_per_hwsku_hostnameinstead ofenum_rand_one_per_hwsku_frontend_hostnameas the original fixture did, causing it to be applied to the supervisor DUT. - The sup doesn't have
DATAACLin it's acl_table causing the key error when the fixture attempts
pre_acl_rules = duthost.acl_facts()["ansible_facts"]["ansible_acl_facts"]["DATAACL"]["rules"]
For the AttributeError: 'SubRequest' object has no attribute 'param' error:
- Run
crm/test_crm.pyon modular - The error occurs in
crm/test_crm.py::test_crm::test_acl_entryfor each of the linecards in a modular system and looks like it's due to expectingenum_rand_one_per_hwsku_frontend_hostnameinstead ofenum_rand_one_per_hwsku_hostname - NOTE: this error signature was observed on fixed system too.
Describe the results you received:
The test failed with error as mentioned.
Describe the results you expected:
Tests should pass
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done