Updating the rules file permissions that appears to be stripped#1
Merged
c-wichmann merged 1 commit intosonic-net:masterfrom Aug 3, 2016
Merged
Updating the rules file permissions that appears to be stripped#1c-wichmann merged 1 commit intosonic-net:masterfrom
c-wichmann merged 1 commit intosonic-net:masterfrom
Conversation
This was referenced Nov 2, 2020
Closed
renukamanavalan
pushed a commit
that referenced
this pull request
Jan 4, 2021
Klish enhancements for sonic-mgmt-framework to improve usability and python3.7 support in Buster
Add two built-in methods for performance enhancement as part of mgmt-framework CLI enhancement:
CLI built-in functions "clish_pyobj" and "clish_restcl" can be use to reduce time taken to execute a command by eliminating the sub-shell interpreter overhead.
The “clish_restcl” method uses libcurl to make REST client call from actioner. The GET operation is not supported as we currently don't handle rendering using jinja templates.
e.g.
oper=PATCH url=/restconf/data/openconfig-interfaces:interfaces/interface=Vlan${vlan-id}/config body={"openconfig-interfaces:config": {"name": "Vlan${vlan-id}"}}
The “clish_pyobj” uses embedding Python to execute the Python scripts to make REST client call via Request package.
e.g.
sonic_cli_if patch_openconfig_interfaces_interfaces_interface_config Vlan${vlan-id}
New PTYPE attribute support - ext_pattern and ext_help with regexp_select method
Similar to the pattern attribute with select method in Opensource Klish, the ext_pattern with regexp_select can be used for auto completion.
e.g.
<PTYPE
name="PHY_INTERFACE"
method="regexp_select"
ext_pattern="Ethernet(port)"
pattern="Ð_ALL_INTF;"
help="" />
An interface name can be specified as “interface Ethernet 1” or “interface Eth1”.
sonic-cli(config)# interface Eth1
sonic-cli(conf-if-Ethernet1)#
Another usacase is that, if multiple options in the same PTYPE are defined to support all possible interface options, the ext_help can be used along with ext_help attributes to provide multiple help string for corresponding options.
e.g.
<PTYPE
name="ALL_INTERFACE"
method="regexp_select"
ext_pattern="Ethernet(Port) PortChannel(1-128) Vlan(1-4093) Loopback(0..16383)"
ext_help="(Ethernet interface type) (PortChannel interface type) (Vlan interface type) (Loopback interface type)"
pattern="Ð_ALL_INTF;|&VLAN_ALL_INTF;|&PO_ALL_INTF;|&LOOPB_INTF;"
help="Interface Type - Ranges"
/>
idle session timeout - CLI session timeout set to 10 minute (600s) to close the session once expired
Interrupt handler to abort the execution of current command
Allow param value with special characters, e.g. “#?\sonic&”
Quoted sting support , e.g. sonic-cli(conf-if-Ethernet1)# description “Azure leaf-#1 NY-datacenter”
hidden command support in klish parser
Patching hook log syslog message to audit command execution through CLI
Add Pylint support
Fix pipe command
Miscellaneous bug fixes - subcommands or param while pressing tab etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.