Subscribe response translation API implementation for the common app module#88
Closed
mbalachandar wants to merge 4 commits intosonic-net:masterfrom
Closed
Subscribe response translation API implementation for the common app module#88mbalachandar wants to merge 4 commits intosonic-net:masterfrom
mbalachandar wants to merge 4 commits intosonic-net:masterfrom
Conversation
…module, to generically translate the database table and key info into corresponding YANG list node key(s) using the YANG schema, annotations, path and key transformers if needed, and populate the converted YANG key into the list node's key value of the URI
sachinholla
suggested changes
May 26, 2023
|
|
||
| func (app *CommonApp) translateSubscribe(req translateSubRequest) (translateSubResponse, error) { | ||
| return emptySubscribeResponse(req.path) | ||
| func (app *CommonApp) translateSubscribe(req *translateSubRequest) (*translateSubResponse, error) { |
Contributor
There was a problem hiding this comment.
Signature does not match the appInterface method:
translateSubscribe(req translateSubRequest) (translateSubResponse, error)| return resp, err | ||
| } | ||
|
|
||
| func (app *CommonApp) processSubscribe(param *processSubRequest) (processSubResponse, error) { |
Contributor
There was a problem hiding this comment.
Signature does not match the appInterface method:
processSubscribe(req processSubRequest) (processSubResponse, error)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscribe response translation API implementation for the common app module, to generically translate the database table and key info into corresponding YANG list node key(s) using the YANG schema, annotations, path and key transformers if needed, and populate the converted YANG key into the list node's key value of the URI
Required for the subscription enhancements as described in HLD sonic-net/SONiC#1287