Subscribe request translation API implementation#78
Merged
anand-kumar-subramanian merged 8 commits intosonic-net:masterfrom May 23, 2023
Merged
Conversation
…o generically identify the db table, key and other related mapping info for the any given path
ayelrod
reviewed
May 18, 2023
ndas7
reviewed
May 19, 2023
Contributor
ndas7
left a comment
ndas7
left a comment
There was a problem hiding this comment.
Adding a few readability comments as per Go Style Guide.
ndas7
reviewed
May 22, 2023
Contributor
ndas7
left a comment
ndas7
left a comment
There was a problem hiding this comment.
LGTM barring a single comment for readability. Thanks.
ndas7
approved these changes
May 22, 2023
tomek-US
approved these changes
May 23, 2023
tomek-US
left a comment
tomek-US
left a comment
There was a problem hiding this comment.
LGTM (based on Lucas's and Neha's review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscribe request translation API implementation for the common app module, to generically identify the mapped DB table, key and other related info for the given subscribe path request using the YANG model, annotations, and other callbacks.
Required for the subscription enhancements as described in HLD sonic-net/SONiC#1287