Skip to content

[CVL] Add support for YANG map-list#148

Closed
ayelrod wants to merge 1 commit intosonic-net:masterfrom
ayelrod:map-list
Closed

[CVL] Add support for YANG map-list#148
ayelrod wants to merge 1 commit intosonic-net:masterfrom
ayelrod:map-list

Conversation

@ayelrod
Copy link
Contributor

@ayelrod ayelrod commented Sep 27, 2024

This change adds support for YANG map-list and map-leaf extensions. This support was removed in #110 and without it, tables defined using map-list and map-leaf do not work.

@DanielaMurin
Copy link

@ayelrod
Hi, I noticed in the #110 commit that map-list and map-leaf were also removed from several yang files (sonic-ext). Are they not needed?

@VladimirKuk
Copy link

Can you add a test for these cases ?

@faraazbrcm
Copy link
Contributor

faraazbrcm commented Oct 1, 2024

@ayelrod

May I know the use case why you need map-leaf and map-list?

Previously it was present to support dynamic fields. But I corrected the implementation in CVL, because it was not adhering to the SONiC YANG guidelines. As per guideline a INNER TABLE should have a single key leaf and single non-key leaf, if the yang adheres to this model schema, the CVL will automatically support dynamic fields for such TABLE.

Please refer PR134, this has an example for table with dynamic fields.

Therefore we dont need these extensions anymore.

@ayelrod
Copy link
Contributor Author

ayelrod commented Oct 1, 2024

Thanks @faraazbrcm. I will use the new schema for supporting dynamic fields.

@ayelrod ayelrod closed this Oct 1, 2024
@ayelrod ayelrod deleted the map-list branch October 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants