[CVL] Add support for YANG map-list#148
Closed
ayelrod wants to merge 1 commit intosonic-net:masterfrom
Closed
Conversation
slicking
approved these changes
Sep 27, 2024
|
Can you add a test for these cases ? |
Contributor
|
May I know the use case why you need map-leaf and map-list? Previously it was present to support dynamic fields. But I corrected the implementation in CVL, because it was not adhering to the SONiC YANG guidelines. As per guideline a INNER TABLE should have a single key leaf and single non-key leaf, if the yang adheres to this model schema, the CVL will automatically support dynamic fields for such TABLE. Please refer PR134, this has an example for table with dynamic fields. Therefore we dont need these extensions anymore. |
Contributor
Author
|
Thanks @faraazbrcm. I will use the new schema for supporting dynamic fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for YANG
map-listandmap-leafextensions. This support was removed in #110 and without it, tables defined usingmap-listandmap-leafdo not work.