Remove kernel config SERIAL_8250_RUNTIME_UARTS#286
Merged
saiarcot895 merged 1 commit intosonic-net:202012from Jul 28, 2022
Merged
Remove kernel config SERIAL_8250_RUNTIME_UARTS#286saiarcot895 merged 1 commit intosonic-net:202012from
saiarcot895 merged 1 commit intosonic-net:202012from
Conversation
Issue: UART parameter of Cisco linux kernel configuration will cause Accton platform not to dump any message on booting stage. Fix: Remove SERIAL_8250_RUNTIME_UARTS config. This will be passed as bootargs to the kernel during bootup. Signed-off-by: Madhava Reddy Siddareddygari <[email protected]>
lguohan
approved these changes
Jul 20, 2022
Contributor
|
Please elaborate the problem. What Accton platform fails to boot, and what is the reason. What is now happening with the Cisco devices? Will they still work? Why was the value set to 32 in the first place? |
paulmenzel
suggested changes
Jul 21, 2022
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Updating GitHub meta data.
Contributor
|
here is the issue. sonic-net/sonic-buildimage#11238 the plan is that cisco will revert this one, and then use kernel bootargs to set it up only for cisco platforms. not sure why it breaks on accton platforms. |
paulmenzel
suggested changes
Jul 21, 2022
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Thank you. Please amend the commit message with a summary of the issue in the commit message, add document Linux CLI parameter name.
saiarcot895
approved these changes
Jul 28, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 29, 2022
Update sonic-linux-kernel submodule pointer to include the following: * Remove kernel config SERIAL_8250_RUNTIME_UARTS ([sonic-net#286](sonic-net/sonic-linux-kernel#286)) Signed-off-by: dprital <[email protected]>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
UART parameter of Cisco linux kernel configuration will cause Accton platform
not to dump any message on booting stage.
Fix:
Remove SERIAL_8250_RUNTIME_UARTS config. This will be passed as bootargs to the
kernel during bootup.
Signed-off-by: Madhava Reddy Siddareddygari [email protected]