[sflow + dropmon] added missing patch for the sFlow + dropmon feature.#281
Merged
saiarcot895 merged 2 commits intosonic-net:masterfrom Jun 24, 2022
Merged
Conversation
vadymhlushko-mlnx
changed the title
12 tasks
Contributor
Author
|
@saiarcot895 could you please review it? |
paulmenzel
suggested changes
Jun 22, 2022
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Please reword the merge/pull request summary and description (describing the problem, the fix, and the tests.), and also update the commit message.
| From 7dbf2689eb841c51dca4dad51b0941c06aa09e26 Mon Sep 17 00:00:00 2001 | ||
| From: Vadym Hlushko <[email protected]> | ||
| Date: Mon, 11 Apr 2022 15:41:46 +0000 | ||
| Subject: [PATCH 3/3] psample: added define PSAMPLE_MD_EXTENDED_ATTR, used in SDK driver sx_psample.c |
Contributor
There was a problem hiding this comment.
Maybe describe the feature instead of the diff.
| From: Vadym Hlushko <[email protected]> | ||
| Date: Mon, 11 Apr 2022 15:41:46 +0000 | ||
| Subject: [PATCH 3/3] psample: added define PSAMPLE_MD_EXTENDED_ATTR, used in SDK driver sx_psample.c | ||
|
|
Contributor
There was a problem hiding this comment.
Please add a elaborate commit message.
Contributor
There was a problem hiding this comment.
Maybe: Define the macro PSAMPLE_MD_EXTENDED_ATTR …
But a very minor nit.
|
I see that the buildimage PR depends on this. Since the other PR is already merged, does it break buildimage? |
Contributor
Author
Yes, it brakes the buildimage |
…ample driver Signed-off-by: Vadym Hlushko <[email protected]>
vadymhlushko-mlnx
force-pushed
the
sflow_dropmon_extended_attr
branch
from
1f3e4cc to
f03f5fa
Compare
saiarcot895
approved these changes
Jun 23, 2022
paulmenzel
reviewed
Jun 23, 2022
Contributor
paulmenzel
left a comment
paulmenzel
left a comment
There was a problem hiding this comment.
Please also update the merge/pull request summary/title.
| From: Vadym Hlushko <[email protected]> | ||
| Date: Mon, 11 Apr 2022 15:41:46 +0000 | ||
| Subject: [PATCH 3/3] psample: added define PSAMPLE_MD_EXTENDED_ATTR, used in SDK driver sx_psample.c | ||
|
|
Contributor
There was a problem hiding this comment.
Maybe: Define the macro PSAMPLE_MD_EXTENDED_ATTR …
But a very minor nit.
Signed-off-by: Vadym Hlushko <[email protected]>
Contributor
Author
Done |
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 9, 2022
Update sonic-linux-kernel submodule pointer to include the following: * [Mellanox] Add new kernel patches from HW-MGMT package V.7.0020.3005 ([sonic-net#287](sonic-net/sonic-linux-kernel#287)) * [patch] mlxsw: i2c: Prevent transaction execution for special chip ([sonic-net#279](sonic-net/sonic-linux-kernel#279)) * [sflow + dropmon] added missing patch for the sFlow + dropmon feature. ([sonic-net#281](sonic-net/sonic-linux-kernel#281)) * [sflow + dropmon] added patches for the sFlow + dropmon feature. ([sonic-net#276](sonic-net/sonic-linux-kernel#276)) Signed-off-by: dprital <[email protected]>
7 tasks
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-linux-kernel
that referenced
this pull request
Aug 15, 2022
sonic-net#281) * [sflow + dropmon] Add patch which add Nvivia-specific flag for the psample driver Signed-off-by: Vadym Hlushko <[email protected]> * Correct patch name Signed-off-by: Vadym Hlushko <[email protected]> This defines the macro PSAMPLE_MD_EXTENDED_ATTR
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-linux-kernel
that referenced
this pull request
Aug 16, 2022
sonic-net#281) * [sflow + dropmon] Add patch which add Nvivia-specific flag for the psample driver Signed-off-by: Vadym Hlushko <[email protected]> * Correct patch name Signed-off-by: Vadym Hlushko <[email protected]> This defines the macro PSAMPLE_MD_EXTENDED_ATTR
vadymhlushko-mlnx
added a commit
to vadymhlushko-mlnx/sonic-linux-kernel
that referenced
this pull request
Aug 16, 2022
sonic-net#281) * [sflow + dropmon] Add patch which add Nvivia-specific flag for the psample driver Signed-off-by: Vadym Hlushko <[email protected]> * Correct patch name Signed-off-by: Vadym Hlushko <[email protected]> This defines the macro PSAMPLE_MD_EXTENDED_ATTR
yxieca
pushed a commit
that referenced
this pull request
Aug 29, 2022
#281) * [sflow + dropmon] Add patch which add Nvivia-specific flag for the psample driver Signed-off-by: Vadym Hlushko <[email protected]> * Correct patch name Signed-off-by: Vadym Hlushko <[email protected]> This defines the macro PSAMPLE_MD_EXTENDED_ATTR
dal00
pushed a commit
to kamelnetworks/sonic-linux-kernel
that referenced
this pull request
Jul 20, 2025
…sonic-net#281) What I did Fix ProcessStatsST column issue Why I did it sonic-net/sonic-host-services#176, when did optimization of the state_db update into batch as dict, not realized "%" is missed, which is a regression issue.  How I verified it Correct typo and added corresponding unit test to cover column name check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a patch with changes required for the
sFlow + dropmonfeature.#define PSAMPLE_MD_EXTENDED_ATTR 1should be declared in thesonic-linux-kernelrepo but used in Switch-SDK-drivers/drivers/net/sx_netdev/sx_psample.cSigned-off-by: Vadym Hlushko [email protected]