Skip to content

Fix some emmc unreliability seen on older AMD CPUs#270

Merged
saiarcot895 merged 1 commit intosonic-net:masterfrom
Staphylo:master-emmc-fixes
Feb 9, 2023
Merged

Fix some emmc unreliability seen on older AMD CPUs#270
saiarcot895 merged 1 commit intosonic-net:masterfrom
Staphylo:master-emmc-fixes

Conversation

@Staphylo
Copy link
Copy Markdown
Contributor

@Staphylo Staphylo commented Feb 17, 2022

Some patches are required to fix some emmc unreliability seen on AMD platforms.
These were ported over from the EOS kernel and applied properly.

paulmenzel
paulmenzel reviewed Feb 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@paulmenzel paulmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have these patches been send for review to the Linux maintainers, so they can get properly reviewed? The SONiC Linux kernel README asks for that.

@paulmenzel
Copy link
Copy Markdown
Contributor

paulmenzel commented Jun 7, 2022

@Staphylo, any updates?

@sujinmkang
Copy link
Copy Markdown
Collaborator

sujinmkang commented Sep 9, 2022

@Staphylo Can you also do easyCLA?

@saiarcot895
Copy link
Copy Markdown
Contributor

saiarcot895 commented Jan 26, 2023

@Staphylo can you rebase this onto the current master branch so that we can get this merged onto the master branch, and cherry-picked for 202211?

@Staphylo
Copy link
Copy Markdown
Contributor Author

Staphylo commented Jan 31, 2023

I just rebased my changes on top of master.

As a side note, if my change to drivers/mmc/host/sdhci-pci-core.c is seen as too dangerous, I could leverage the append_quirk* change to encode all the necessary quirks via the cmdline for the affected product only.

sdhci.append_quirk=0x20 sdhci.append_quirk2=0x240

It would amount to enabling:

  • SDHCI_QUIRK_BROKEN_ADMA
  • SDHCI_QUIRK2_BROKEN_64_BIT_DMA
  • SDHCI_QUIRK2_BROKEN_HS200

@Staphylo
Copy link
Copy Markdown
Contributor Author

Staphylo commented Feb 3, 2023

@prgeor for visibility

@prgeor prgeor requested a review from lguohan February 3, 2023 22:53
@prgeor prgeor self-assigned this Feb 3, 2023
@saiarcot895
Copy link
Copy Markdown
Contributor

saiarcot895 commented Feb 7, 2023

Are there plans to upstream, at minimum, patch/driver-arista-mmcblk-not-working-on-AMD-platforms.patch?

@Staphylo
Copy link
Copy Markdown
Contributor Author

Staphylo commented Feb 9, 2023

Are there plans to upstream, at minimum, patch/driver-arista-mmcblk-not-working-on-AMD-platforms.patch?

There is currently no plan to upstream this.
As mentioned in my previous comment, if that's a problem for you I could do everything via kernel parameters and drop driver-arista-mmcblk-not-working-on-AMD-platforms.patch

@saiarcot895 saiarcot895 merged commit 4c2d457 into sonic-net:master Feb 9, 2023
@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Feb 9, 2023

@Staphylo please help create an PR for 202205 branch.

@StormLiangMS
Copy link
Copy Markdown
Contributor

StormLiangMS commented Feb 10, 2023

@saiarcot895 @xumia could we enable default PR format for this repo? Like PR need to include below info.

Why I did it
How I did it
How to verify it

StormLiangMS pushed a commit that referenced this pull request Feb 10, 2023
@Staphylo @StormLiangMS
Fixes for emmc unreliability (#270)
6365701
@Staphylo
Copy link
Copy Markdown
Contributor Author

Staphylo commented Feb 10, 2023

@yxieca this fix is already on 202205.
The only diff is in the patch description since I added a few lines here.
I don't think there's anything to do for 202205.

AntonHryshchuk added a commit to AntonHryshchuk/sonic-buildimage that referenced this pull request Feb 22, 2023
@AntonHryshchuk
[submodule] Advance sonic-linux-kernel pointer
ba174b1 
Update sonic-linux-kernel submodule pointer to include the following:
* 4c2d457 Fixes for emmc unreliability ([sonic-net#270](sonic-net/sonic-linux-kernel#270))

Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Feb 23, 2023
@dprital
[submodule] Advance sonic-linux-kernel pointer
2441699 
Update sonic-linux-kernel submodule pointer to include the following:
* 4c2d457 Fixes for emmc unreliability ([sonic-net#270](sonic-net/sonic-linux-kernel#270))

Signed-off-by: dprital <drorp@nvidia.com>
@dprital dprital mentioned this pull request Feb 23, 2023
Merged
8 tasks
lguohan pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Feb 27, 2023
@dprital
[submodule] Advance sonic-linux-kernel pointer (#13955)
2566f78 
Update sonic-linux-kernel submodule pointer to include the following:
* 4c2d457 Fixes for emmc unreliability ([#270](sonic-net/sonic-linux-kernel#270))

Signed-off-by: dprital <drorp@nvidia.com>
xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
@dprital @xumia
[submodule] Advance sonic-linux-kernel pointer (sonic-net#13955)
49aead2 
Update sonic-linux-kernel submodule pointer to include the following:
* 4c2d457 Fixes for emmc unreliability ([sonic-net#270](sonic-net/sonic-linux-kernel#270))

Signed-off-by: dprital <drorp@nvidia.com>
mihirpat1 pushed a commit to mihirpat1/sonic-linux-kernel that referenced this pull request Mar 10, 2023
@Staphylo @mihirpat1
Fixes for emmc unreliability (sonic-net#270)
cb1a8e7
prgeor added a commit that referenced this pull request Mar 16, 2023
@mihirpat1 @Staphylo @prgeor
Read ID register for optoe1 to find pageable bit in optoe driver (#308)
6847319 
* Fixes for emmc unreliability (#270)

* Read ID register to find pageable bit in optoe driver

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Modified comment in code to make it QSFP specific

* Changed QSFP+ to QSFP28 in comment

* Added performance stats related to EEPROM read

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Co-authored-by: Samuel Angebault <staphylo@arista.com>
Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
yxieca pushed a commit that referenced this pull request Mar 17, 2023
@mihirpat1 @Staphylo
@prgeor @yxieca
Read ID register for optoe1 to find pageable bit in optoe driver (#308)
49d2a42 
* Fixes for emmc unreliability (#270)

* Read ID register to find pageable bit in optoe driver

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Modified comment in code to make it QSFP specific

* Changed QSFP+ to QSFP28 in comment

* Added performance stats related to EEPROM read

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Co-authored-by: Samuel Angebault <staphylo@arista.com>
Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
StormLiangMS pushed a commit that referenced this pull request Apr 13, 2023
@mihirpat1 @Staphylo
@prgeor @StormLiangMS
Read ID register for optoe1 to find pageable bit in optoe driver (#308)
4a0f2b1 
* Fixes for emmc unreliability (#270)

* Read ID register to find pageable bit in optoe driver

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Modified comment in code to make it QSFP specific

* Changed QSFP+ to QSFP28 in comment

* Added performance stats related to EEPROM read

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Co-authored-by: Samuel Angebault <staphylo@arista.com>
Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saiarcot895 saiarcot895 saiarcot895 approved these changes

@lguohan lguohan Awaiting requested review from lguohan

+1 more reviewer

@paulmenzel paulmenzel paulmenzel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@prgeor prgeor

Labels

Included in 202211 Branch Request for 202211 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Staphylo @paulmenzel @sujinmkang @saiarcot895 @yxieca @StormLiangMS @prgeor