Skip to content

Adding support to compile ARM architecture#102

Merged
lguohan merged 12 commits intosonic-net:masterfrom
antony-rheneus:linux-arm-support
Jan 26, 2020
Merged

Adding support to compile ARM architecture#102
lguohan merged 12 commits intosonic-net:masterfrom
antony-rheneus:linux-arm-support

Conversation

@antony-rheneus
Copy link
Contributor

@antony-rheneus antony-rheneus commented Sep 30, 2019

Added support for ARM arch to get compiled from sonic-linux-kernel.
Kernel config/build files are generated for all 3archs AMD64, ARMHF, ARM64 irresective of the target architecture. So that series of patches can be maintained in a single file across arch.

Signed-off-by: Antony Rheneus arheneus@marvell.com

ARM32 arch config uses armmp including lpae

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
ARM32 arch config uses armmp including lpae

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@lguohan
Copy link
Contributor

lguohan commented Oct 8, 2019

why build fails? is that expected?

@antony-rheneus
Copy link
Contributor Author

why build fails? is that expected?

It should not fail.
Below is the error, which failed in some git command.
ERROR: Build step failed with exception
java.io.IOException: Cannot retrieve Git metadata for the build
Build step 'Set GitHub commit status (universal)' marked build as failure

Will trigger build again to check it.

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@lguohan
Copy link
Contributor

lguohan commented Oct 9, 2019

can you not separate the config file for amd64 and arm? also for patch list, can you use same patch list?

Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for kernel configuration change, I'd like to you distribute the patch into per feature instead of having an arch specific patch.

@antony-rheneus
Copy link
Contributor Author

for kernel configuration change, I'd like to you distribute the patch into per feature instead of having an arch specific patch.

Then we have to go with Approach 1 of #102 (comment)

@lguohan
Copy link
Contributor

lguohan commented Oct 9, 2019

agree with you approach 1 is better.

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
@antony-rheneus antony-rheneus changed the title Adding support to compile ARM 32 and ARM 64 architecture Adding support to compile ARM architecture Oct 21, 2019
From 3a09f684413faf1c4f7d21d7d79914b54e087cf6 Mon Sep 17 00:00:00 2001
From: Antony Rheneus <arheneus@marvell.com>
Date: Thu, 17 Oct 2019 10:48:29 +0530
Subject: [PATCH] armhf default config for the sonic patches
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to patches in Kconfig, kernel make enters into into interactive mode for user to provide (N/m/y) options.
Few configs like Mellanox Platform are not relevant but still config has to set with "N" (not set) option.
To avoid all manual changes in config, I have generated "default" configs for ARMHF and ARM64 after applying patch with "not set/N" option, wich reduced manual effort of finding right place to insert CONFIG variables.

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

config GENERIC_ISA_DMA
- bool
+ def_bool y
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed for generate_dump script which read /proc/dma file.
in ARM (32bit) Arch, /proc/dma is enabled by this change

@antony-rheneus antony-rheneus mentioned this pull request Dec 17, 2019
@lguohan
Copy link
Contributor

lguohan commented Jan 24, 2020

retest this please

2 similar comments
@lguohan
Copy link
Contributor

lguohan commented Jan 24, 2020

retest this please

@lguohan
Copy link
Contributor

lguohan commented Jan 26, 2020

retest this please

@lguohan lguohan merged commit 90f7c84 into sonic-net:master Jan 26, 2020
lguohan added a commit that referenced this pull request Feb 3, 2020
* Adding support to compile ARM 32 and ARM 64 architecture
ARM32 arch config uses armmp including lpae

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

* Adding support to compile ARM 32 and ARM 64 architecture
ARM32 arch config uses armmp including lpae

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

* [Patch] armhf marvell defconfig

* [Patch] Removed patch for marvell defconfig as it is NOT used

* [Makerfile] Added comment for armhf

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

* [Patch] Removed maintaing spearate file for arm

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

* [Arm] Added configuraiton needed for ARMHF platform

Signed-off-by: Antony Rheneus <arheneus@marvell.com>

Co-authored-by: lguohan <lguohan@gmail.com>
antony-rheneus added a commit to antony-rheneus/sonic-linux-kernel that referenced this pull request Feb 11, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
antony-rheneus added a commit to antony-rheneus/sonic-linux-kernel that referenced this pull request Feb 13, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 16, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 16, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request May 8, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request May 8, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Jul 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
taocy001 pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Jul 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
guxianghong pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Nov 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
guxianghong pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Nov 12, 2020
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
guxianghong pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 12, 2021
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
guxianghong pushed a commit to CentecNetworks/sonic-linux-kernel that referenced this pull request Mar 12, 2021
Adding support to compile ARM architecture (sonic-net#102)

2. Added support for marvell Armada A7020 Arm64

Signed-off-by: Antony Rheneus <arheneus@marvell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants