Keep incrementing sequence number when link prober is suspended and shutdown #55#65
Merged
zjswhhh merged 2 commits intosonic-net:202012from Apr 15, 2022
Merged
Conversation
yxieca
approved these changes
Apr 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Unable to cherry-pick the commit below cleanly from master branch:
13f4879 Jing Zhang Sun Apr 3 21:56:33 2022 -0700 Keep incrementing sequence number when link prober is suspended and shutdown (#55)
Summary:
Fixes # (issue)
This PR is fix the issue when both sides' link prober is suspended, LinkManager still appears to be healthy.
When HB suspends, TX sequence number is not updated either, hence link prober won't post an
unknownevent.sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
Make sure link prober is reporting
unknownevent when it's suspended or shutdown on both sides.How did you do it?
Increment sequence number even when HB is not sent.
How did you verify/test it?
Tested on dualToR testbed.
Any platform specific information?
Documentation