Disable the feature that decreases link probe interval for measuring switch overhead #49#54
Merged
zjswhhh merged 2 commits intosonic-net:202012from Apr 1, 2022
Merged
Conversation
yxieca
approved these changes
Apr 1, 2022
Contributor
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
This is not really what asked but it gets the feature disabled for now.
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
Apr 15, 2022
…switch overhead sonic-net#49 (sonic-net#54) ### Description of PR Can't cleanly cherry pick the commit from master branch: 34a68d1 disable switchover measuring based on link prober (sonic-net#49) Summary: Fixes # (issue) Disable part of the feature introduced in sonic-net#43. The link probing interval will NOT be decreased by default. Link prober state change events will still be posted in `LINK_PROBE_STATS|PORTNAME` in state db. sign-off: Jing Zhang zhangjing@microsoft.com ### Type of change - [x] New feature ### Approach #### What is the motivation for this PR? We need to reconsider the design of this feature. To be more specific, this is a special case of decreasing probing interval, it's for measurement purposes only. We still want to trigger the toggle in 300ms when pack loss happens. The negative count should be 30 instead of 3 when interval is decreased to 10ms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Can't cleanly cherry pick the commit from master branch:
34a68d1 disable switchover measuring based on link prober (#49)
Summary:
Fixes # (issue)
Disable part of the feature introduced in #43.
The link probing interval will NOT be decreased by default. Link prober state change events will still be posted in
LINK_PROBE_STATS|PORTNAMEin state db.sign-off: Jing Zhang zhangjing@microsoft.com
Type of change
Approach
What is the motivation for this PR?
We need to reconsider the design of this feature.
To be more specific, this is a special case of decreasing probing interval, it's for measurement purposes only. We still want to trigger the toggle in 300ms when pack loss happens. The negative count should be 30 instead of 3 when interval is decreased to 10ms.
How did you do it?
How did you verify/test it?
Any platform specific information?
Documentation