Closed
Conversation
Explicitly add test main function to enable customized testing features: 1. initialize mux logger before tests. 2. introduce `gmock` Signed-off-by: Longxiang Lyu <[email protected]>
bingwang-ms
approved these changes
Mar 21, 2022
6 tasks
lolyu
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
Why I did it Add libgmock-dev to the package list required by linkmgrd unittests. Required by PR: sonic-net/sonic-linkmgrd#45 How I did it Add the package to the package list. How to verify it Build docker-mux with KEEP_SLAVE_ON=yes and verify libgmock-dev is present. Signed-off-by: Longxiang Lyu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Explicitly add test main function to enable customized testing features:
gmockDepends on: sonic-net/sonic-buildimage#10294
Signed-off-by: Longxiang Lyu [email protected]
How did you do it?
LinkMgrdTestMain.cppto explicitly define main function.gmockHow did you verify/test it?
Any platform specific information?
Documentation