Skip to content

[python tests] Fix determine-reboot-cause_test.py importing module sonic_platform #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
judsonwilson-nvidia wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[python tests] Fix determine-reboot-cause_test.py importing module sonic_platform #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests/determine-reboot-cause_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,21 @@
from swsscommon import swsscommon
from sonic_py_common.general import load_module_from_source


# The platform-specific module `sonic_platform` may or may not be installed on the system hosting
# the tests. In the build containers, it may coincidentally be installed, depending on the build
# order. But, this test and the modules it tests are designed for the `sonic_platform` module to be
# absent in the test environment. E.g., code that depends on DeviceInfo is bypassed when
# `import sonic_platform` fails; otherwise, if it succeeds, and the environment is not set up like
# a SONiC device host, the platform information may not be available and exceptions are thrown.
# So remove the module if it's imported, and set to None to block a future import.
@pytest.fixture(scope="module", autouse=True)
def _remove_sonic_platform():
with pytest.MonkeyPatch.context() as mp:
mp.setitem(sys.modules, 'sonic_platform', None)
yield


# TODO: Remove this if/else block once we no longer support Python 2
if sys.version_info.major == 3:
from unittest import mock
Expand Down
Loading