Ignore sonic_platform package fileNotFoundError on non-chassis vs platforms#133
Merged
deepak-singhal0408 merged 1 commit intosonic-net:masterfrom Jun 22, 2024
Conversation
11 tasks
arlakshm
approved these changes
Jun 21, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-host-services
that referenced
this pull request
Jul 23, 2024
|
Cherry-pick PR to 202405: #140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
For T2 vs chassis support, sonic_platform package was introduced as part of PR sonic-net/sonic-buildimage#18512
Even though this package will be present on all VS platforms, its a no-op on non-chassis VS platforms. On VS Chassis platforms, this requires a metadata file, which will not be available on pizza box VS platforms.
As part of determine-reboot-cause script, this sonic_platform package is imported, which is throwing FIleNotFoundError on vs platforms, where this metadata file is not present.
Fix: Added this FileNotFoundError in exception, as this is under a determine_reboot_cause_from_platform check, which is NA on VS platforms.