Fix Go buildvcs error in Trixie build environment#622
Merged
hdwhdw merged 1 commit intosonic-net:masterfrom Mar 18, 2026
Merged
Fix Go buildvcs error in Trixie build environment#622hdwhdw merged 1 commit intosonic-net:masterfrom
hdwhdw merged 1 commit intosonic-net:masterfrom
Conversation
Go 1.18+ enables VCS stamping by default via -buildvcs=true. In the sonic-buildimage dpkg build environment, the .git directory is not available, causing 'go install' to fail with: error obtaining VCS status: directory "." is not using a known version control system Set GOFLAGS=-buildvcs=false in debian/rules to disable VCS stamping during package builds. Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Debian packaging to disable Go’s default VCS stamping during builds, avoiding failures when the .git directory is not present (common in dpkg build environments like sonic-buildimage).
Changes:
- Export
GOFLAGSwith-buildvcs=falseindebian/rulesto prevent VCS stamping during Debian package builds.
hdwhdw
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go 1.18+ enables VCS stamping by default (
-buildvcs=true). In the sonic-buildimage dpkg build environment, the.gitdirectory is not available, causinggo installto fail with:This was observed in the Trixie migration build: sonic-net/sonic-buildimage#25957
Fix
Set
GOFLAGS += -buildvcs=falseindebian/rulesto disable VCS stamping during package builds.Testing