Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions gnmi_server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,16 @@ func authenticate(config *Config, ctx context.Context, target string, writeAcces
var err error
success := false
rc, ctx := common_utils.GetContext(ctx)

// Skip authentication for UDS (Unix Domain Socket) connections.
// UDS security is enforced at the file-system level via socket permissions.
if pr, ok := peer.FromContext(ctx); ok && pr.Addr != nil {
if _, isUnix := pr.Addr.(*net.UnixAddr); isUnix {
rc.Auth.AuthEnabled = false
return ctx, nil
}
}

if !config.UserAuth.Any() {
//No Auth enabled
rc.Auth.AuthEnabled = false
Expand Down
25 changes: 25 additions & 0 deletions gnmi_server/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"flag"
"fmt"
"io/ioutil"
"net"
"os"
"os/exec"
"os/user"
Expand Down Expand Up @@ -6364,6 +6365,30 @@ func TestAuthenticate(t *testing.T) {
cancel()
}

func createUDSCtx() (context.Context, context.CancelFunc) {
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
p := peer.Peer{
Addr: &net.UnixAddr{Name: "/tmp/test.sock", Net: "unix"},
}
ctx = peer.NewContext(ctx, &p)
return ctx, cancel
}

func TestAuthenticateUDS(t *testing.T) {
cfg := &Config{UserAuth: AuthTypes{"password": false, "cert": true, "jwt": false}}

for _, target := range []string{"gnmi", "gnoi"} {
for _, write := range []bool{false, true} {
ctx, cancel := createUDSCtx()
_, err := authenticate(cfg, ctx, target, write)
if err != nil {
t.Errorf("%s (write=%v) over UDS should succeed: %v", target, write, err)
}
cancel()
}
}
}

type MockServerStream struct {
grpc.ServerStream
}
Expand Down
Loading