Add conditional check for split#55
Merged
zbud-msft merged 9 commits intosonic-net:masterfrom Nov 22, 2022
Merged
Conversation
Contributor
|
Can you add unit test for this case? |
Collaborator
|
Please check if we can backport this PR to release branches. |
Collaborator
|
I notice something wrong with coverage checker "No lines with coverage information in this diff." |
Contributor
https://github.com/sonic-net/sonic-gnmi/blob/master/Makefile#L74-L76 |
tomek-US
reviewed
Nov 16, 2022
zbud-msft
force-pushed
the
BugFixInvalidDBKey
branch
from
a0df2bf to
43438e2
Compare
tomek-US
approved these changes
Nov 21, 2022
ganglyu
approved these changes
Nov 22, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Nov 28, 2022
Update sonic-gnmi submodule pointer to include the following: * 99bfa8f Remove LOGLEVEL DB since is no longer used ([#56](sonic-net/sonic-gnmi#56)) * 6b0253a Add conditional check for split ([#55](sonic-net/sonic-gnmi#55)) * ae72767 Add gnmi_dump tool for debug and unit test ([#60](sonic-net/sonic-gnmi#60)) * 8226e46 Upgrade pipeline to use bullseye. ([#58](sonic-net/sonic-gnmi#58)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
This was referenced Nov 29, 2022
ganglyu
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 29, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
StormLiangMS
pushed a commit
to StormLiangMS/sonic-buildimage
that referenced
this pull request
Dec 8, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
StormLiangMS
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 10, 2022
Why I did it Submodule update for sonic-gnmi Incorporates: 8226e46 Upgrade pipeline to use bullseye. (sonic-net/sonic-gnmi#58) ae72767 Add gnmi_dump tool for debug and unit test (sonic-net/sonic-gnmi#60) 6b0253a Add conditional check for split (sonic-net/sonic-gnmi#55) 99bfa8f Remove LOGLEVEL DB since is no longer used (sonic-net/sonic-gnmi#56) 54806a8 Support new gnmi config interface in telemetry container. (sonic-net/sonic-gnmi#7) How I did it Move submodule How to verify it Check build pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Can crash if no delimitor is present and accessing second part of split
Crash stack
How I did it
Added conditional check
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)