Support control character in config#217
Merged
ganglyu merged 1 commit intosonic-net:masterfrom Apr 18, 2024
Merged
Conversation
liuh-80
approved these changes
Apr 18, 2024
ganglyu
added a commit
to ganglyu/sonic-gnmi
that referenced
this pull request
Jun 18, 2024
Why I did it sonic-net/sonic-buildimage#16957 Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config. How I did it Update yang validation part to read config from file. How to verify it Run GNMI end to end test.
ganglyu
added a commit
to ganglyu/sonic-gnmi
that referenced
this pull request
Jun 18, 2024
Why I did it sonic-net/sonic-buildimage#16957 Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config. How I did it Update yang validation part to read config from file. How to verify it Run GNMI end to end test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
sonic-net/sonic-buildimage#16957
Above PR introduced "\n" in config_db, and current GNMI implementation does not support such config.
How I did it
Update yang validation part to read config from file.
How to verify it
Run GNMI end to end test.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)