[dhcp_relay] sonic dhcp relay agent for IPv4 by cshivashgit · Pull Request #67 · sonic-net/sonic-dhcp-relay

cshivashgit · 2025-04-30T13:26:10Z

Why I did it
DHCP Relay agent for IPv4

How I did it
Merging dhcp4 changes into this repo, created dhcp6[existing code] and dhcp4[new code] folders

HLD link:
https://github.com/sonic-net/SONiC/blob/2eb20e2d2bcc181ab8cf1f502173ac0dbd528698/doc/DHCPv4_relay/DHCPv4-relay-agent-High-Level-Design.md

mssonicbld · 2025-04-30T13:26:19Z

/azp run

azure-pipelines · 2025-04-30T13:26:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-04-30T13:53:05Z

/azp run

azure-pipelines · 2025-04-30T13:53:15Z

Azure Pipelines successfully started running 1 pipeline(s).

ashutosh-agrawal · 2025-04-30T16:40:00Z

@yaqiangz Appreciate if you can provide feedback on the directory/file structure.

mssonicbld · 2025-05-02T10:39:18Z

/azp run

azure-pipelines · 2025-05-02T10:39:27Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-02T13:57:34Z

/azp run

azure-pipelines · 2025-05-02T13:57:43Z

Azure Pipelines successfully started running 1 pipeline(s).

…and dhcp4relay[new code] folders Co-authored-by: Akshath TR <akshath.t.r@gmail.com> Co-authored-by: Ashutosh Agrawal <ashu@cisco.com>

mssonicbld · 2025-05-07T03:55:19Z

/azp run

azure-pipelines · 2025-05-07T03:55:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-22T04:28:15Z

/azp run

azure-pipelines · 2025-05-22T04:28:24Z

Azure Pipelines successfully started running 1 pipeline(s).

dhcp4relay/src/dhcp4relay.cpp

dhcp4relay/src/dhcp4relay_mgr.cpp

dhcp4relay/src/dhcp4relay_stats.cpp

dhcp4relay/src/dhcp4relay.cpp

mssonicbld · 2025-07-03T14:13:08Z

/azp run

azure-pipelines · 2025-07-03T14:13:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-10-30T03:46:49Z

/azp run

azure-pipelines · 2025-10-30T03:46:59Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-10-30T05:06:31Z

/azp run

azure-pipelines · 2025-10-30T05:06:41Z

Azure Pipelines successfully started running 1 pipeline(s).

Added missed declarations

mssonicbld · 2025-10-30T06:45:28Z

/azp run

azure-pipelines · 2025-10-30T06:45:37Z

Azure Pipelines successfully started running 1 pipeline(s).

Move pcappp_v24.09.zip and patch folder inside dhcp4relay directory

mssonicbld · 2025-10-30T10:15:35Z

/azp run

azure-pipelines · 2025-10-30T10:15:45Z

Azure Pipelines successfully started running 1 pipeline(s).

Blueve · 2025-11-03T04:04:44Z

Close and re-open to rerun PR test

mssonicbld · 2025-11-03T04:04:56Z

/azp run

azure-pipelines · 2025-11-03T04:05:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>

Fixed a typo to retrigger PR checks

mssonicbld · 2025-11-03T21:15:12Z

/azp run

azure-pipelines · 2025-11-03T21:15:20Z

Azure Pipelines successfully started running 1 pipeline(s).

saiarcot895 · 2025-12-07T23:38:03Z

dhcp4relay/pcappp_v24.09.zip

Why is there a random zip file added here? If this is actually needed as a build dependency, compile it as a separate application or add it into the slave container.

@saiarcot895 Since, we are applying a minor patch on top of the downloaded PCAP++ source code, we didn't include it in the slave container. But I've modified the build process to now download the file instead of including it in the code. Please review the changes in this PR

- Replace 17MB pcappp_v24.09.zip binary with wget download from GitHub - Download from official release: github.com/seladb/PcapPlusPlus/archive/refs/tags/v24.09.tar.gz - Add SHA256 checksum verification (b14998ecf5718c2bfb6f709060e53f7ef67639b98bf2222a3cd23d820d70acdc) - Fix patch file paths to apply cleanly (remove PcapPlusPlus-24.09/ prefix) - Add .gitignore to exclude downloaded artifacts Addresses review comment from saiarcot895 on PR sonic-net#67

* [sonic-dhcp4relay]: Defect fixes Below sonic-mgmt issues are fixed: 1. Random source port 2. Padding issues 3. DHCP Server fixes Signed-off-by: Shivashankar CR <shivashankar.c.r@gmail.com> * [sonic-dhcp4relay] Smart switch support Signed-off-by: Shivashankar CR <shivashankar.c.r@gmail.com> * Remove binary zip file and download PcapPlusPlus during build - Replace 17MB pcappp_v24.09.zip binary with wget download from GitHub - Download from official release: github.com/seladb/PcapPlusPlus/archive/refs/tags/v24.09.tar.gz - Add SHA256 checksum verification (b14998ecf5718c2bfb6f709060e53f7ef67639b98bf2222a3cd23d820d70acdc) - Fix patch file paths to apply cleanly (remove PcapPlusPlus-24.09/ prefix) - Add .gitignore to exclude downloaded artifacts Addresses review comment from saiarcot895 on PR #67 --------- Signed-off-by: Shivashankar CR <shivashankar.c.r@gmail.com> Co-authored-by: Ashutosh Agrawal <ashu@cisco.com>

cshivashgit force-pushed the sonic-dhcp4relay branch from f4847c1 to cfd6970 Compare April 30, 2025 13:52

ashutosh-agrawal mentioned this pull request Apr 30, 2025

DHCPv4 Relay Agent High Level Design sonic-net/SONiC#1938

Merged

cshivashgit force-pushed the sonic-dhcp4relay branch from cfd6970 to 4ab5782 Compare May 2, 2025 10:39

cshivashgit force-pushed the sonic-dhcp4relay branch from 4ab5782 to cb1b92f Compare May 2, 2025 13:57

Introducing dhcp v4 relay changes, created dhcp6relay[existing code] …

37d3981

…and dhcp4relay[new code] folders Co-authored-by: Akshath TR <akshath.t.r@gmail.com> Co-authored-by: Ashutosh Agrawal <ashu@cisco.com>

cshivashgit force-pushed the sonic-dhcp4relay branch from cb1b92f to 37d3981 Compare May 7, 2025 03:55

Addressing MSFT comments on HLD

dffb7e7

yaqiangz reviewed Jun 24, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay.cpp Outdated Show resolved Hide resolved

yaqiangz reviewed Jun 24, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay_mgr.cpp Outdated Show resolved Hide resolved

yaqiangz reviewed Jul 1, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay_stats.cpp Outdated Show resolved Hide resolved

yaqiangz reviewed Jul 1, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay_stats.cpp Outdated Show resolved Hide resolved

yaqiangz reviewed Jul 1, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay.cpp Outdated Show resolved Hide resolved

yaqiangz reviewed Jul 1, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay.cpp Show resolved Hide resolved

yaqiangz reviewed Jul 1, 2025

View reviewed changes

dhcp4relay/src/dhcp4relay.cpp Show resolved Hide resolved

Added code changes to support DualTor and dhcp_server

a4f3fe1

Fixing pcap++ build

9377abe

Modified swss-common's CFG definitions

92e6506

Added missed declarations

cshivashgit force-pushed the sonic-dhcp4relay branch from 8248735 to 92e6506 Compare October 30, 2025 06:45

Additional CFG definitions update

c2ce158

Move pcappp_v24.09.zip and patch folder inside dhcp4relay directory

Blueve previously approved these changes Nov 3, 2025

View reviewed changes

Blueve closed this Nov 3, 2025

Blueve reopened this Nov 3, 2025

ashutosh-agrawal added 2 commits November 3, 2025 13:13

fixed a typo to retrigger PR checks

9faa343

Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>

Merge pull request #2 from cshivashgit/ashu/typo-fix

b565380

Fixed a typo to retrigger PR checks

ashutosh-agrawal dismissed Blueve’s stale review via b565380 November 3, 2025 21:15

Blueve approved these changes Nov 5, 2025

View reviewed changes

Blueve merged commit 8772dd5 into sonic-net:master Nov 5, 2025
8 checks passed

saiarcot895 reviewed Dec 7, 2025

View reviewed changes

ashutosh-agrawal mentioned this pull request Dec 8, 2025

Remove binary zip file and download PcapPlusPlus during build cshivashgit/sonic-dhcp-relay#4

Merged

Conversation

cshivashgit commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Apr 30, 2025

Uh oh!

azure-pipelines bot commented Apr 30, 2025

Uh oh!

mssonicbld commented Apr 30, 2025

Uh oh!

azure-pipelines bot commented Apr 30, 2025

Uh oh!

ashutosh-agrawal commented Apr 30, 2025

Uh oh!

mssonicbld commented May 2, 2025

Uh oh!

azure-pipelines bot commented May 2, 2025

Uh oh!

mssonicbld commented May 2, 2025

Uh oh!

azure-pipelines bot commented May 2, 2025

Uh oh!

mssonicbld commented May 7, 2025

Uh oh!

azure-pipelines bot commented May 7, 2025

Uh oh!

mssonicbld commented May 22, 2025

Uh oh!

azure-pipelines bot commented May 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jul 3, 2025

Uh oh!

azure-pipelines bot commented Jul 3, 2025

Uh oh!

mssonicbld commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

mssonicbld commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

mssonicbld commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

mssonicbld commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

Blueve commented Nov 3, 2025

Uh oh!

mssonicbld commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

mssonicbld commented Nov 3, 2025

Uh oh!

azure-pipelines bot commented Nov 3, 2025

Uh oh!

Uh oh!

saiarcot895 Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

ashutosh-agrawal Dec 8, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

cshivashgit commented Apr 30, 2025 •

edited

Loading