[dhcprelay] Replace memset function#12
Merged
yxieca merged 3 commits intosonic-net:masterfrom Aug 29, 2022
maipbui:dhcprelay_replace_memset
Merged
[dhcprelay] Replace memset function#12yxieca merged 3 commits intosonic-net:masterfrom maipbui:dhcprelay_replace_memset
yxieca merged 3 commits intosonic-net:masterfrom
maipbui:dhcprelay_replace_memset
Conversation
Signed-off-by: maipbui <[email protected]>
qiluo-msft
reviewed
Aug 22, 2022
Signed-off-by: maipbui <[email protected]>
qiluo-msft
reviewed
Aug 24, 2022
Signed-off-by: maipbui <[email protected]>
qiluo-msft
approved these changes
Aug 26, 2022
kellyyeh
approved these changes
Aug 27, 2022
kellyyeh
pushed a commit
to kellyyeh/sonic-dhcp-relay
that referenced
this pull request
Oct 8, 2022
Why I did it memset() is insecure function that can cause buffer overflow How I did it Replace memset() by zero initialization Signed-off-by: maipbui <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: maipbui [email protected]
Why I did it
Due to compiler optimization: an optimizing compiler, which identifies and removes the function that overwrites the contents as a dead store because the memory is not used subsequently. If sensitive data is in memory, it's dangerous if compiler optimization happens.
Ref:
https://cwe.mitre.org/data/definitions/14.html
https://registry.semgrep.dev/rule/c.lang.security.insecure-use-memset.insecure-use-memset
How I did it
Replace
memset()by zero initialization