[lldp] add lldpRemManAddrTable, lldpLocManAddrTable#8
Merged
qiluo-msft merged 5 commits intosonic-net:masterfrom Aug 2, 2018
Merged
[lldp] add lldpRemManAddrTable, lldpLocManAddrTable#8qiluo-msft merged 5 commits intosonic-net:masterfrom
qiluo-msft merged 5 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Jul 20, 2018
|
|
||
| def run(self): | ||
|
|
||
| self.port_table_init() |
Contributor
There was a problem hiding this comment.
del the empty line? #Closed
qiluo-msft
reviewed
Jul 20, 2018
src/lldp_syncd/dbsyncd.py
Outdated
| self.config_db.connect() | ||
| logger.info("[lldp dbsyncd] Connected to configdb") | ||
| self.port_table = {} | ||
| self.man_addr = None |
Contributor
There was a problem hiding this comment.
man_addr [](start = 13, length = 8)
not used? #Closed
qiluo-msft
reviewed
Jul 20, 2018
src/lldp_syncd/dbsyncd.py
Outdated
| from sonic_syncd import SonicSyncDaemon | ||
| from . import logger | ||
|
|
||
| MGMT_INTERFACE_PATTERN = r"MGMT_INTERFACE*" |
Contributor
There was a problem hiding this comment.
MGMT_INTERFACE_PATTERN [](start = 0, length = 22)
not used? #Closed
qiluo-msft
reviewed
Jul 20, 2018
src/lldp_syncd/dbsyncd.py
Outdated
| self.port_table[key] = data | ||
|
|
||
| def run(self): | ||
| def man_addr_init(self): |
Contributor
There was a problem hiding this comment.
man_addr_init [](start = 8, length = 13)
mgmt_addr_init #Closed
qiluo-msft
reviewed
Jul 20, 2018
src/lldp_syncd/dbsyncd.py
Outdated
| self.config_db.subscribe('PORT', lambda table, key, data: | ||
| self.port_handler(key, data)) | ||
|
|
||
| self.man_addr_init() |
Contributor
There was a problem hiding this comment.
man_addr_init [](start = 13, length = 13)
man_addr_init before subscribe? #Closed
Contributor
Contributor
Author
|
Hi @qiluo-msft , I handled previous comments, can you take a look? |
qiluo-msft
approved these changes
Jul 26, 2018
Contributor
qiluo-msft
approved these changes
Aug 2, 2018
qiluo-msft
reviewed
Aug 11, 2018
| self.hset(h, k, v) | ||
|
|
||
| elif db == 4: | ||
| with open(INPUT_DIR + '/CONFIG_DB.json') as f: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
Also requires sonic-net/sonic-snmpagent#72
lldpRemManAddrTable
lldpLocManAddrTable