Add test case to verify zmq reconnect behaviour#84
Merged
r12f merged 2 commits intosonic-net:masterfrom Jul 18, 2025
Merged
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Jul 18, 2025
qiluo-msft
added a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Jul 19, 2025
This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. why During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. PUSH/PULL model ZMQ_IMMEDIATE = 0 (default) ZMQ_SNDHWM = 10000 what this PR does add unit test for zmq late connect and reconnect for regression remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. update test_utils/README.md with missing argument to start redis in test environment
|
Cherry-pick PR to msft-202506: Azure/sonic-dash-ha.msft#6 |
mssonicbld
added
Included in msft-202506 Branch
and removed
Created PR to msft-202506 Branch
labels
mssonicbld
added a commit
to mssonicbld/sonic-swss-common.msft
that referenced
this pull request
Jul 31, 2025
This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. ### why During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. - PUSH/PULL model - ZMQ_IMMEDIATE = 0 (default) - ZMQ_SNDHWM = 10000 ### what this PR does - add unit test for zmq late connect and reconnect for regression - remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. - update test_utils/README.md with missing argument to start redis in test environment
prabhataravind
pushed a commit
to Azure/sonic-swss-common.msft
that referenced
this pull request
Jul 31, 2025
This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. ### why During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. - PUSH/PULL model - ZMQ_IMMEDIATE = 0 (default) - ZMQ_SNDHWM = 10000 ### what this PR does - add unit test for zmq late connect and reconnect for regression - remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. - update test_utils/README.md with missing argument to start redis in test environment
wen587
pushed a commit
to wen587/sonic-swss-common
that referenced
this pull request
Aug 5, 2025
…-net#1052) This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. why During investigating issue sonic-net#75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. PUSH/PULL model ZMQ_IMMEDIATE = 0 (default) ZMQ_SNDHWM = 10000 what this PR does add unit test for zmq late connect and reconnect for regression remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. update test_utils/README.md with missing argument to start redis in test environment
mssonicbld
added a commit
to mssonicbld/sonic-swss-common.msft
that referenced
this pull request
Sep 10, 2025
This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. ### why During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. - PUSH/PULL model - ZMQ_IMMEDIATE = 0 (default) - ZMQ_SNDHWM = 10000 ### what this PR does - add unit test for zmq late connect and reconnect for regression - remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. - update test_utils/README.md with missing argument to start redis in test environment
mssonicbld
added a commit
to Azure/sonic-swss-common.msft
that referenced
this pull request
Sep 10, 2025
This PR is a partial duplicate of sonic-net/sonic-dash-ha#84 Since crates/swss-common will be moved in this repo. ### why During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly. - PUSH/PULL model - ZMQ_IMMEDIATE = 0 (default) - ZMQ_SNDHWM = 10000 ### what this PR does - add unit test for zmq late connect and reconnect for regression - remove unneeded code for falling back to ProducerStateTable in test environment since zmq client won't fail if zmq server is not connected. - update test_utils/README.md with missing argument to start redis in test environment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
During investigating issue #75, I created test case to verify zmq behaviour in handling no connection and connection loss. It is found that with the current swss-common zmq implementation with below attributes, we don't need to handle reconnect explicitly.
what this PR does