Change to DBConnector::clone_timeout_async#132
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Nov 29, 2025
Merged
Conversation
… be removed - also reorganize reference to swss-common and swss-common-testing so all crates use the same version
|
/azp run |
qiluo-msft
approved these changes
Nov 29, 2025
qiluo-msft
added a commit
to sonic-net/sonic-swss-common
that referenced
this pull request
Nov 29, 2025
unwrap() function may crash in runtime. Drop should not crash. Clone should not crash, so remove it. Protect casting Duration Depends on sonic-net/sonic-dash-ha#132
mssonicbld
added a commit
to mssonicbld/sonic-swss-common
that referenced
this pull request
Dec 4, 2025
unwrap() function may crash in runtime. Drop should not crash. Clone should not crash, so remove it. Protect casting Duration Depends on sonic-net/sonic-dash-ha#132
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Change DBConnector::clone_async to DBConnector::clone_timeout_async
Also reorganize references to swss-common and swss-common-testing so all crates using the same version
Why I did it
DBConnector::clone_async will be removed and it is only a wrapper over clone_timeout_async
How I verified it
Rerun UT
Details if related