[mellanox] Remove redundant breakout mode for SN3800#9912
Merged
prgeor merged 2 commits intosonic-net:masterfrom Feb 6, 2022
Merged
[mellanox] Remove redundant breakout mode for SN3800#9912prgeor merged 2 commits intosonic-net:masterfrom
prgeor merged 2 commits intosonic-net:masterfrom
Conversation
alexrallen
requested review from
prgeor,
sujinmkang and
vdahiya12
as code owners
prgeor
approved these changes
Feb 3, 2022
dgsudharsan
approved these changes
Feb 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
With #9278 we no longer need to specify breakout modes with a different default speed separately.
How I did it
Removed discrete 1x10G breakout mode from SN3800 platform.json file
How to verify it
Apply the Mellanox-SN3800-D28C49S1 SKU and verify all ports are configured as expected.
Which release branch to backport (provide reason below if selected)
The mentioned fix was backported to 202111 so I figure this should be backported as well to be aligned.
546818f
Description for the changelog
[mellanox] Remove redundant breakout mode for SN3800
A picture of a cute animal (not mandatory but encouraged)