[dhcp6relay] a couple memory access protections#9851
Merged
yxieca merged 3 commits intosonic-net:masterfrom Jan 26, 2022
Merged
[dhcp6relay] a couple memory access protections#9851yxieca merged 3 commits intosonic-net:masterfrom
yxieca merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Use config->interface->c_str() directly without strcpy. The original strcpy code has memory corruption due to adding null terminator. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
saiarcot895
approved these changes
Jan 26, 2022
kellyyeh
approved these changes
Jan 26, 2022
5 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jan 31, 2022
Why I did it the strcpy and buffer allocation is not safe, it corrupts 1 byte on the stack. Depending on the memory layout, it may or may not cause issue immediately. message type is not validated before updating the counter. Which could cause segment fault. How I did it Remove the unsafe strcpy, use config->interface.c_str() instead. Check message type before updating counters. How to verify it The issue (1) caused segment fault on a specific platform. The fix was validated there. Issue (2) was precautionary. Added log in case it triggers.
kellyyeh
added
the
Request for 202111 Branch
judyjoseph
pushed a commit
that referenced
this pull request
Feb 22, 2022
Why I did it the strcpy and buffer allocation is not safe, it corrupts 1 byte on the stack. Depending on the memory layout, it may or may not cause issue immediately. message type is not validated before updating the counter. Which could cause segment fault. How I did it Remove the unsafe strcpy, use config->interface.c_str() instead. Check message type before updating counters. How to verify it The issue (1) caused segment fault on a specific platform. The fix was validated there. Issue (2) was precautionary. Added log in case it triggers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Included in 201811 Branch
Included in 202012 Branch
Included in 202111 Branch
Request for 201811 Branch 
Request for 202012 Branch
Request for 202111 Branch
For PRs being requested for 202111 branch
Request for 202012 Branch
Request for 202111 Branch
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
How I did it
How to verify it
The issue (1) caused segment fault on a specific platform. The fix was validated there. Issue (2) was precautionary. Added log in case it triggers.