Dell S6100: Addition of 10G ports#9820
Merged
tjchadaga merged 1 commit intosonic-net:masterfrom Jan 26, 2022
Merged
Conversation
aravindmani-1
requested review from
prgeor,
sujinmkang and
vdahiya12
as code owners
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
tjchadaga
approved these changes
Jan 25, 2022
lguohan
pushed a commit
that referenced
this pull request
Jan 27, 2022
Master image build break - changes to reviewed and re-merged with appropriate fix
```
======================================================================
FAIL: test_buffers_dell6100_render_template (tests.test_j2files.TestJ2Files)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/sonic/src/sonic-config-engine/tests/test_j2files.py", line 246, in test_buffers_dell6100_render_template
self._test_buffers_render_template('dell', 'x86_64-dell_s6100_c2538-r0', 'Force10-S6100', 'sample-dell-6100-t0-minigraph.xml', 'buffers.json.j2', 'buffers-dell6100.json')
File "/sonic/src/sonic-config-engine/tests/test_j2files.py", line 243, in _test_buffers_render_template
assert filecmp.cmp(sample_output_file, self.output_file)
AssertionError
```
This reverts commit 5334712.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To fix #9475
How I did it
Added 10G ports back.
How to verify it
Check whether Orchagent crashes after the fix. Verify syslogs,CLI commands
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)