[yang]: Update yang models to support 'cluster'#9806
Merged
ganglyu merged 3 commits intosonic-net:masterfrom Jan 26, 2022
Merged
[yang]: Update yang models to support 'cluster'#9806ganglyu merged 3 commits intosonic-net:masterfrom
ganglyu merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Gang Lv ganglv@microsoft.com
ganglyu
added
sonic-cfggen
ganglyu
requested review from
dgsudharsan,
praveen-li,
qiluo-msft,
rathnasabapathyv,
renukamanavalan and
venkatmahalingam
Signed-off-by: Gang Lv ganglv@microsoft.com
qiluo-msft
previously approved these changes
Jan 20, 2022
renukamanavalan
previously approved these changes
Jan 21, 2022
| } | ||
|
|
||
| leaf cluster { | ||
| type string; |
Collaborator
There was a problem hiding this comment.
Please add a description, what does this field contain? when is it used?
Contributor
There was a problem hiding this comment.
A cluster is a set of inter-connected computers or hosts. The switches that sits in front belongs to the cluster.
This is a general Networking terminology. -- Wikipedia
Description: The switch is a member of this cluster.
Signed-off-by: Gang Lv ganglv@microsoft.com
ganglyu
dismissed stale reviews from renukamanavalan and qiluo-msft
via
09660be
ganglyu
requested review from
qiluo-msft,
renukamanavalan and
venkatmahalingam
renukamanavalan
approved these changes
Jan 24, 2022
Contributor
Author
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jan 25, 2022
Contributor
Author
|
@venkatmahalingam could you please review again? |
venkatmahalingam
approved these changes
Jan 26, 2022
ganglyu
added
the
Request for 202111 Branch
Contributor
|
There is merge conflict in 202111, please raise a separate PR |
judyjoseph
removed
the
Request for 202111 Branch
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gang Lv ganglv@microsoft.com
Why I did it
Minigraph parser added a new field 'cluster' to device_metadata, and then yang validation is blocked.
How I did it
Add 'cluster' to device_metadata yang models.
How to verify it
Run UT for sonc-yang-models.
Use minigraph parser to generate ConfigDB schema and run yang validation.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix #9699
A picture of a cute animal (not mandatory but encouraged)