Skip to content

[yang]: AAA login pattern #9805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuh-80 merged 3 commits into from
Mar 7, 2022
Merged

[yang]: AAA login pattern #9805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e12e7c
[yang]: AAA login pattern
Jan 20, 2022
9c49558
Fix typo
Jan 20, 2022
cc58a54
Improve login pattern
liuh-80 Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/aaa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
"desc": "Configure a wrong type in AAA table.",
"eStrKey": "InvalidValue"
},
"AAA_TEST_WRONG_LOGIN": {
"desc": "Configure a wrong type in AAA table.",
"eStr": ["Invalid login choice"]
},
"AAA_TEST_WRONG_FAILTHROUGH": {
"desc": "Configure a wrong failthrough in AAA table.",
"eStrKey": "Pattern",
Expand Down
10 changes: 10 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests_config/aaa.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@
}
},

"AAA_TEST_WRONG_LOGIN": {
"sonic-system-aaa:sonic-system-aaa": {
"sonic-system-aaa:AAA": {
"AAA_LIST": [{
"login": "locallll"
}]
}
}
},

"AAA_TEST_WRONG_FAILTHROUGH": {
"sonic-system-aaa:sonic-system-aaa": {
"sonic-system-aaa:AAA": {
Expand Down
8 changes: 6 additions & 2 deletions src/sonic-yang-models/yang-models/sonic-system-aaa.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,12 @@ module sonic-system-aaa {
}

leaf login {
type string;
description "AAA authentication/authorization/accounting methods - local/tacacs+/disable";
type string {
pattern '((tacacs\+|local|radius|default),)*(tacacs\+|local|radius|default)' {
error-message "Invalid login choice";
}
}
description "AAA authentication/authorization/accounting methods - radius/tacacs+/local/default";
default "local";
}

Expand Down