[swss]: Reduce tunnel_packet_handler memory usage#9762
Merged
theasianpianist merged 2 commits intosonic-net:masterfrom Feb 7, 2022
Merged
[swss]: Reduce tunnel_packet_handler memory usage#9762theasianpianist merged 2 commits intosonic-net:masterfrom
theasianpianist merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Contributor
|
let's plan to add a sonic-mgmt test for this. Mainly since we are manipulating the netlink attribute and in case future kernel versions has any change, it would be easy to catch. |
prsunny
previously approved these changes
Jan 20, 2022
| name was found | ||
| """ | ||
| Gets a mapping of interface kernel indices to portchannel interfaces | ||
| attr_list = msg['attrs'] |
Contributor
There was a problem hiding this comment.
will there be a case if attr_list is null?
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Feb 6, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 8, 2022
* Configure scapy to not store sniffed packets Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
Why I did it
The tunnel packet handler gradually leaks memory
How I did it
link_lookupmethod from the Pyroute2 librarystore=0argument for the Scapy snifferHow to verify it
docker statWhich release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)