Fix libyang backlinks issue: by li-pingmao · Pull Request #9545 · sonic-net/sonic-buildimage

li-pingmao · 2021-12-15T20:00:53Z

Fix libyang backlinks and sonic-yang-mgmt find_data_dependency issues:
1) changes of find_data_dependency():
- remove call to libyang backlinks()
- find data dependencies/backlinks based on schema and data tree python APIs
2) Add test of yang model with union of leafrefs

Why I did it

1.  libyang dropped python binding backlinks() API with newer version
2. old 1.0.173 python backlinks() API does not find the data dependencies/backlinks in case of union of leafrefs

How I did it

remove call to libyang backlinks()
changes of find_data_dependency():
find data dependencies/backlinks based on schema and data tree python APIs

How to verify it

Add test cases of yang model with union of leafrefs

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

lgtm-com · 2021-12-15T20:39:30Z

This pull request introduces 1 alert when merging c1c7fb885022cb3f91e9f76c26940c3d8256a381 into 727a946 - view on LGTM.com

new alerts:

1 for Testing equality to None

src/sonic-yang-mgmt/tests/libyang-python-tests/config_data.json

zhangyanzhao · 2022-01-27T18:08:54Z

Ping will follow-up with Mohamed and Praveen offline.

…NG container (#2047) #### What I did Did a debug session with Ping Mao and found this case is failing in her PR: sonic-net/sonic-buildimage#9545 I think it is an interesting case and I added it explicitly to GCU. Adding unit-test where path and ref paths are under the same YANG container [sonic-loopback-interface.yang](https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-loopback-interface.yang) has: ```yang container sonic-loopback-interface { container LOOPBACK_INTERFACE { list LOOPBACK_INTERFACE_LIST { ... leaf name{ type string; } ... list LOOPBACK_INTERFACE_IPPREFIX_LIST { leaf name{ ... type leafref { path "../../LOOPBACK_INTERFACE_LIST/name"; } } ... ``` #### How I did it Unit-test added #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)

liat-grozovik · 2022-02-22T17:12:05Z

@li-pingmao can you please resolve conflict so we can move forward with the review?
this one is blocking the NVGRE PR to be un reverted due to this issue.

li-pingmao · 2022-02-22T20:51:23Z

Sure, looking into it.

lgtm-com · 2022-02-23T00:56:02Z

This pull request introduces 1 alert when merging 3f9c59c1a10e1ccb507add09a2c54c0b80761703 into 55e7a14 - view on LGTM.com

new alerts:

1 for Testing equality to None

- remove call of libyang backlinks() call - find data dependencies based on python schema and data tree APIs - Add test of yang model with union of leafrefs

src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/test-vlan.yang

liat-grozovik · 2022-02-27T08:27:15Z

/azp run

azure-pipelines · 2022-02-27T08:27:21Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

qiluo-msft · 2022-03-17T00:10:03Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-03-17T00:10:16Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2022-03-17T05:54:05Z

Seems sonic-utilities unit test is stuck.

2022-03-17T00:41:35.7419046Z tests/config_dpb_test.py::TestConfigDPB::test_get_breakout_options PASSED [  8%]
2022-03-17T00:41:35.7420084Z tests/config_dpb_test.py::TestConfigDPB::test_config_breakout_extra_table_warning PASSED [  8%]
2022-03-17T00:41:35.7421887Z [  FAIL LOG END  ] [ target/python-wheels/bullseye/sonic_utilities-1.2-py3-none-any.whl ]
2022-03-17T00:41:35.7486017Z make: *** [slave.mk:676: target/python-wheels/bullseye/sonic_utilities-1.2-py3-none-any.whl] Error 1
2022-03-17T00:41:35.7486717Z make: *** Waiting for unfinished jobs....

zhangyanzhao · 2022-03-17T17:10:55Z

This PR is failing sonic-utilities test and
test_find_ref_paths__path_and_ref_paths_are_under_same_yang_container__returns_ref_paths, need @li-pingmao help to fix.

zhangyanzhao · 2022-03-17T17:22:46Z

option Update README.md #1: change ACL yang model as workaround
option Update README.md #2: upgrade libyang to latest version but it has no binding function (delivered by separate package)
@li-pingmao will raise PR for option Update README.md #1.

zhangyanzhao · 2022-04-28T15:52:40Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2022-04-28T15:52:53Z

Azure Pipelines successfully started running 1 pipeline(s).

zhangyanzhao · 2022-04-28T17:18:59Z

Ping debugged with Mohamed, still need more investigation on new test cases.

zhangyanzhao · 2022-08-04T17:18:06Z

@ganglyu

zhangyanzhao · 2022-09-08T17:06:24Z

@li-pingmao can you please join next YANG subgroup meeting and provide an update? Thanks.

zhangyanzhao · 2022-09-22T17:31:13Z

libyang owner proposed a new option and @ganglyu is working on it.

…NG container (#2047) #### What I did Did a debug session with Ping Mao and found this case is failing in her PR: sonic-net/sonic-buildimage#9545 I think it is an interesting case and I added it explicitly to GCU. Adding unit-test where path and ref paths are under the same YANG container [sonic-loopback-interface.yang](https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/yang-models/sonic-loopback-interface.yang) has: ```yang container sonic-loopback-interface { container LOOPBACK_INTERFACE { list LOOPBACK_INTERFACE_LIST { ... leaf name{ type string; } ... list LOOPBACK_INTERFACE_IPPREFIX_LIST { leaf name{ ... type leafref { path "../../LOOPBACK_INTERFACE_LIST/name"; } } ... ``` #### How I did it Unit-test added #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)

bradh352 · 2025-02-12T16:12:01Z

this should be closed in favor of #21679

li-pingmao requested a review from lguohan as a code owner December 15, 2021 20:00

qiluo-msft requested review from dgsudharsan, ghooo, praveen-li and rathnasabapathyv December 16, 2021 00:46

qiluo-msft added the Request for 202111 Branch For PRs being requested for 202111 branch label Dec 16, 2021

qiluo-msft reviewed Dec 16, 2021

View reviewed changes

src/sonic-yang-mgmt/tests/libyang-python-tests/config_data.json Outdated Show resolved Hide resolved

zhangyanzhao added the YANG YANG model related changes label Jan 27, 2022

ghooo mentioned this pull request Jan 27, 2022

[GCU] Adding unit-test where path and ref paths are under the same YANG container sonic-net/sonic-utilities#2047

Merged

li-pingmao force-pushed the master-libyang branch from c1c7fb8 to 3f9c59c Compare February 23, 2022 00:33

Fix libyang backlinks issue:

94ac50b

- remove call of libyang backlinks() call - find data dependencies based on python schema and data tree APIs - Add test of yang model with union of leafrefs

li-pingmao force-pushed the master-libyang branch from 3f9c59c to 94ac50b Compare February 23, 2022 01:08

qiluo-msft reviewed Feb 23, 2022

View reviewed changes

src/sonic-yang-mgmt/tests/libyang-python-tests/sample-yang-models/test-vlan.yang Outdated Show resolved Hide resolved

Fix identation

318ab50

li-pingmao requested a review from a team as a code owner June 10, 2022 02:01

ghooo mentioned this pull request Jul 25, 2022

[yang-models] Importing other modules sometimes break libyang backlinks #9312

Open

zhangyanzhao assigned ganglyu Sep 22, 2022

ganglyu mentioned this pull request Feb 7, 2025

[libyang bug] workaround leaf-list via uses bug in BGP route-map #21078

Closed

1 task

Conversation

li-pingmao commented Dec 15, 2021

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

lgtm-com bot commented Dec 15, 2021

Uh oh!

Uh oh!

zhangyanzhao commented Jan 27, 2022

Uh oh!

liat-grozovik commented Feb 22, 2022

Uh oh!

li-pingmao commented Feb 22, 2022

Uh oh!

lgtm-com bot commented Feb 23, 2022

Uh oh!

Uh oh!

liat-grozovik commented Feb 27, 2022

Uh oh!

azure-pipelines bot commented Feb 27, 2022

Uh oh!

qiluo-msft commented Mar 17, 2022

Uh oh!

azure-pipelines bot commented Mar 17, 2022

Uh oh!

qiluo-msft commented Mar 17, 2022

Uh oh!

zhangyanzhao commented Mar 17, 2022

Uh oh!

zhangyanzhao commented Mar 17, 2022

Uh oh!

zhangyanzhao commented Apr 28, 2022

Uh oh!

azure-pipelines bot commented Apr 28, 2022

Uh oh!

zhangyanzhao commented Apr 28, 2022

Uh oh!

zhangyanzhao commented Aug 4, 2022

Uh oh!

zhangyanzhao commented Sep 8, 2022

Uh oh!

zhangyanzhao commented Sep 22, 2022

Uh oh!

bradh352 commented Feb 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants