[multiasic][database]database.sh failed to create the database for namespace in multiasic platform#9502
Merged
abdosi merged 1 commit intosonic-net:masterfrom Dec 13, 2021
Conversation
…mespace The latest code Docker version 20.10.x, command "docker create" no longer takes optional "NET=" with empty value. Syntax error show with currecnt docker create command in database.sh Signed-off-by: mlok <[email protected]>
abdosi
added
Request for 202111 Branch
abdosi
approved these changes
Dec 10, 2021
Contributor
Author
|
@abdosi @judyjoseph @minionatwork Please review this PR for fix the latest docker create. Thanks |
judyjoseph
reviewed
Dec 10, 2021
| fi | ||
|
|
||
| {%- if docker_container_name == "database" %} | ||
| NET="bridge" |
Contributor
There was a problem hiding this comment.
This setting was present earlier eg: 201911 release etc. It got removed in one of the PR's #5283
judyjoseph
approved these changes
Dec 10, 2021
minionatwork
approved these changes
Dec 10, 2021
SuvarnaMeenakshi
approved these changes
Dec 10, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Dec 27, 2021
…mespace (#9502) Why I did it database.sh failed to create the database for namespace in multiasic platform. The latest code Docker version 20.10.x, command "docker create" no longer takes optional "NET=" with empty value. Syntax error show with current docker create command in database.sh. Issue #9503 How I did it Modify the docker_image_ctl.j2 to set default network setting NET="bridge" instead of empty for namespace database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
database.sh failed to create the database for namespace in multiasic platform.
The latest code Docker version 20.10.x, command "docker create" no longer takes optional "NET=" with empty value. Syntax error show with current docker create command in database.sh. Issue #9503
How I did it
Modify the docker_image_ctl.j2 to set default network setting NET="bridge" instead of empty for namespace database.
How to verify it
boot up the new image in a multiasic platform. the namespace database containers should be created. Also the following error message should not be seen in syslog file
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)