[mux]: Fix mark_dhcp_packet#9373
Merged
theasianpianist merged 3 commits intosonic-net:masterfrom Nov 29, 2021
Merged
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
|
This pull request fixes 3 alerts when merging 921091a into 80dfbc8 - view on LGTM.com fixed alerts:
|
lguohan
approved these changes
Nov 24, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Dec 1, 2021
- Consolidate the two [Service] sections by moving the ExecStartPre line for mark_dhcp_packet.py to the first section and removing the second.
- Make the mark_dhcp_packet.py file executable
- Also clean up mark_dhcp_packet.py
- Remove unused imports
- Fix spacing and line lengths to conform to PEP8
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9374
Why I did it
Two issues prevent the
muxsystemd service from starting properly:mux.serviceunit file contains two[Service]sections, making it invalidmark_dhcp_packet.pyfile is not executable in the imageHow I did it
[Service]sections by moving theExecStartPreline formark_dhcp_packet.pyto the first section and removing the second.mark_dhcp_packet.pyfile executablemark_dhcp_packet.pyHow to verify it
muxservice start properly:Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)