[sonic-config-engine] Fix unit test case minigraph_acl failure. by liushilongbuaa · Pull Request #9305 · sonic-net/sonic-buildimage

liushilongbuaa · 2021-11-18T10:56:07Z

Why I did it

Fix sonic-config-engine unit test case minigraph_acl failure.

How I did it

Ignore sonic-cfggen warnings. Because output assertEqual is enough.

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

lguohan · 2021-11-18T17:34:10Z

src/sonic-config-engine/tests/test_cfggen.py

i think there is reason why such warning is checked. better not to remove this. what else warning are we seeing?

I agree with @lguohan comments. I was able to verify it without removing that line #206. Just the below line should work i believe.

output = self.run_script(argument)

I checked other test cases. No one else checked warning output.

i am not fully convinced that we can ignore the warning here.

$ grep run_script src/sonic-config-engine/tests/ src/sonic-config-engine/tests/test_cfggen.py:50: src/sonic-config-engine/tests/test_cfggen.py:71: src/sonic-config-engine/tests/test_cfggen.py:76: src/sonic-config-engine/tests/test_cfggen.py:81: src/sonic-config-engine/tests/test_cfggen.py:86: src/sonic-config-engine/tests/test_cfggen.py:91: src/sonic-config-engine/tests/test_cfggen.py:96: src/sonic-config-engine/tests/test_cfggen.py:101: src/sonic-config-engine/tests/test_cfggen.py:106: src/sonic-config-engine/tests/test_cfggen.py:111: src/sonic-config-engine/tests/test_cfggen.py:116: src/sonic-config-engine/tests/test_cfggen.py:123: src/sonic-config-engine/tests/test_cfggen.py:128: src/sonic-config-engine/tests/test_cfggen.py:133: src/sonic-config-engine/tests/test_cfggen.py:138: src/sonic-config-engine/tests/test_cfggen.py:145: src/sonic-config-engine/tests/test_cfggen.py:169: src/sonic-config-engine/tests/test_cfggen.py:174: src/sonic-config-engine/tests/test_cfggen.py:182: src/sonic-config-engine/tests/test_cfggen.py:196: src/sonic-config-engine/tests/test_cfggen.py:206: src/sonic-config-engine/tests/test_cfggen.py:225:# src/sonic-config-engine/tests/test_cfggen.py:230: src/sonic-config-engine/tests/test_cfggen.py:238: src/sonic-config-engine/tests/test_cfggen.py:244: src/sonic-config-engine/tests/test_cfggen.py:259: src/sonic-config-engine/tests/test_cfggen.py:284: src/sonic-config-engine/tests/test_cfggen.py:289: src/sonic-config-engine/tests/test_cfggen.py:299: src/sonic-config-engine/tests/test_cfggen.py:307: src/sonic-config-engine/tests/test_cfggen.py:317: src/sonic-config-engine/tests/test_cfggen.py:325: src/sonic-config-engine/tests/test_cfggen.py:333: src/sonic-config-engine/tests/test_cfggen.py:341: src/sonic-config-engine/tests/test_cfggen.py:349: src/sonic-config-engine/tests/test_cfggen.py:360: src/sonic-config-engine/tests/test_cfggen.py:374: src/sonic-config-engine/tests/test_cfggen.py:383: src/sonic-config-engine/tests/test_cfggen.py:392: src/sonic-config-engine/tests/test_cfggen.py:433: src/sonic-config-engine/tests/test_cfggen.py:474: src/sonic-config-engine/tests/test_cfggen.py:482: src/sonic-config-engine/tests/test_cfggen.py:490: src/sonic-config-engine/tests/test_cfggen.py:498: src/sonic-config-engine/tests/test_cfggen.py:504: src/sonic-config-engine/tests/test_cfggen.py:510: src/sonic-config-engine/tests/test_cfggen.py:518: src/sonic-config-engine/tests/test_cfggen.py:561: src/sonic-config-engine/tests/test_cfggen.py:604: src/sonic-config-engine/tests/test_cfggen.py:647:# src/sonic-config-engine/tests/test_cfggen.py:652: src/sonic-config-engine/tests/test_cfggen.py:660: src/sonic-config-engine/tests/test_cfggen.py:666: src/sonic-config-engine/tests/test_cfggen.py:672: src/sonic-config-engine/tests/test_cfggen.py:677: src/sonic-config-engine/tests/test_cfggen.py:685: src/sonic-config-engine/tests/test_cfggen.py:693: src/sonic-config-engine/tests/test_cfggen.py:729: src/sonic-config-engine/tests/test_cfggen.py:747: src/sonic-config-engine/tests/test_cfggen.py:752: src/sonic-config-engine/tests/test_cfggen.py:766: src/sonic-config-engine/tests/test_cfggen.py:806: src/sonic-config-engine/tests/test_cfggen.py:811: src/sonic-config-engine/tests/test_cfggen.py:816: src/sonic-config-engine/tests/test_cfggen.py:825: src/sonic-config-engine/tests/test_cfggen.py:843: src/sonic-config-engine/tests/test_cfggen.py:856: src/sonic-config-engine/tests/test_cfggen.py:869: src/sonic-config-engine/tests/test_cfggen.py:885: src/sonic-config-engine/tests/test_cfggen.py:896: src/sonic-config-engine/tests/test_cfggen.py:904: src/sonic-config-engine/tests/test_cfggen.py:911: src/sonic-config-engine/tests/test_cfggen.py:919: -rn
def run_script(self, argument, check_stderr=False, verbose=False):
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument, True, True)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = json.loads(self.run_script(argument))
json.loads(self.run_script(argument)),
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)
output = self.run_script(argument)

We can see only this test case checked warning. What's the different between this case and others?

liushilongbuaa requested a review from lguohan as a code owner November 18, 2021 10:56

liushilongbuaa added Request for 202006 Branch Request for 202012 Branch Request for 202106 Branch Unit Tests labels Nov 18, 2021

lguohan reviewed Nov 18, 2021

View reviewed changes

liushilongbuaa force-pushed the shilongfix branch from 645039a to 7317dd0 Compare November 22, 2021 02:27

liushilongbuaa mentioned this pull request Nov 23, 2021

[build] Fix rules/functions generate_manifest function #9340

Merged

5 tasks

[unit test] Fix test_minigraph_acl warning.

8fe63cb

liushilongbuaa force-pushed the shilongfix branch from 7317dd0 to 8fe63cb Compare November 23, 2021 03:28

liushilongbuaa requested a review from lguohan November 23, 2021 03:29

liushilongbuaa closed this Nov 30, 2021

liushilongbuaa deleted the shilongfix branch October 18, 2022 07:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[sonic-config-engine] Fix unit test case minigraph_acl failure.#9305

[sonic-config-engine] Fix unit test case minigraph_acl failure.#9305
liushilongbuaa wants to merge 1 commit intosonic-net:masterfrom
liushilongbuaa:shilongfix

liushilongbuaa commented Nov 18, 2021 •

edited

Loading

Uh oh!

lguohan Nov 18, 2021

Uh oh!

VenkatCisco Nov 19, 2021

Uh oh!

liushilongbuaa Nov 19, 2021

Uh oh!

lguohan Nov 25, 2021

Uh oh!

liushilongbuaa Nov 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

liushilongbuaa commented Nov 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

lguohan Nov 18, 2021

Choose a reason for hiding this comment

Uh oh!

VenkatCisco Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

liushilongbuaa Nov 19, 2021

Choose a reason for hiding this comment

Uh oh!

lguohan Nov 25, 2021

Choose a reason for hiding this comment

Uh oh!

liushilongbuaa Nov 25, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

liushilongbuaa commented Nov 18, 2021 •

edited

Loading