[dhcp_relay] Update DHCPv6 counter on relayed messages#9283
Merged
kellyyeh merged 4 commits intosonic-net:masterfrom Dec 1, 2021
Merged
[dhcp_relay] Update DHCPv6 counter on relayed messages#9283kellyyeh merged 4 commits intosonic-net:masterfrom
kellyyeh merged 4 commits intosonic-net:masterfrom
Conversation
kellyyeh
force-pushed
the
kellyyeh-dhcp6-counter-master
branch
from
3fff918 to
09c59f0
Compare
kellyyeh
changed the title
yxieca
reviewed
Nov 18, 2021
yxieca
previously approved these changes
Nov 19, 2021
yxieca
reviewed
Nov 19, 2021
| /* DHCPv6 Counter */ | ||
| uint64_t counters[DHCPv6_MESSAGE_TYPE_COUNT]; | ||
| std::map<int, std::string> counterMap = {{1, "Solicit"}, | ||
| std::map<int, std::string> counterMap = {{0, "Unknown"}, |
Contributor
There was a problem hiding this comment.
Do you need to add initialization code for 'Unknown' in initialize_counter()?
kellyyeh
force-pushed
the
kellyyeh-dhcp6-counter-master
branch
from
6f0865e to
63d6905
Compare
yxieca
approved these changes
Nov 19, 2021
Contributor
Author
|
/Azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
kellyyeh
added a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
Dec 17, 2021
(cherry picked from commit f2ee94d)
This was referenced Dec 17, 2021
kellyyeh
added a commit
that referenced
this pull request
Dec 17, 2021
qiluo-msft
added
Request for 202012 Branch
and removed
Request for 202012 Branch
labels
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
DHCPv6 Counter updates counter only on received messages, not relayed messages
How I did it
Update counter on messages relayed by DHCPv6 Relay
How to verify it
Update counter on messages relayed by DHCPv6 Relay
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)
Signed off by Kelly Yeh: kellyyeh@microsoft.com