[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228
Merged
qiluo-msft merged 11 commits intosonic-net:202012from Nov 23, 2021
Merged
[hostcfgd] [202012] Fixed the brief blackout in hostcfgd using SubscriberStateTable #9228qiluo-msft merged 11 commits intosonic-net:202012from
qiluo-msft merged 11 commits intosonic-net:202012from
Conversation
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com> d03ba4fa [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) 499ad3f4 [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) 96d658c2 [202012][sonic installer] Add swap setup support (sonic-net#1815) a9c69702 platform pre-check for reboot in 202012 branch (sonic-net#1788) 0e0478ba Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) 2d1e00ed [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789)
…to hostcfg_fix_202012
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Contributor
Author
|
@qiluo-msft, Can you review this? |
qiluo-msft
reviewed
Nov 11, 2021
src/sonic-host-services/setup.py
Outdated
| setup_requires = [ | ||
| 'pytest-runner', | ||
| 'wheel' | ||
| 'wheel', |
Collaborator
Contributor
Author
There was a problem hiding this comment.
I'm sorry. Removed this comma. Cherry pick in this case wasn't possible. As the code for Feature Handler has diverged a lot and the master version has changes related to auto_restart param, i had to rewrite instead
qiluo-msft
reviewed
Nov 11, 2021
| import subprocess | ||
| import syslog | ||
| import signal | ||
| import sys |
Collaborator
There was a problem hiding this comment.
Seems like you change order during backport. It will make others backport difficult in general. Could you try minimize new changes during the backport?
Contributor
Author
There was a problem hiding this comment.
Reordered imports and added safe_eval method
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
qiluo-msft
approved these changes
Nov 12, 2021
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@qiluo-msft The pipeline is passing now. Can you please help with the merge? |
qiluo-msft
reviewed
Nov 22, 2021
|
|
||
| def aaa_handler(self, key, data): | ||
| def aaa_handler(self, key, op, data): | ||
| self.aaacfg.aaa_update(key, data) |
Collaborator
There was a problem hiding this comment.
You missed a syslog statement, comparing with #8861
qiluo-msft
approved these changes
Nov 22, 2021
Contributor
Author
|
@qiluo-msft, CI checks are passing, can you help signoff? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Backporting #8861 to 202012
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)