dhcp6relay: remove line overwriting docker-dhcp-relay variable#9179
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 6, 2021
Merged
dhcp6relay: remove line overwriting docker-dhcp-relay variable#9179lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
The dhcp6relay rules file had a line overwriting a variable for docker-dhcp-relay. Remove that line. This line caused a limited impact where if some (many?) of the docker containers were already built, except for dhcp-relay, and the build failed or was interrupted, then dhcp-relay container would fail to build because this variable was overwritten and the python3-swsscommon wouldn't get installed into the slave container. Most builds would be fine, though. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
saiarcot895
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
kellyyeh
approved these changes
Nov 5, 2021
Collaborator
|
do we need this for 202012? |
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 9, 2021
The dhcp6relay rules file had a line overwriting a variable for docker-dhcp-relay. Remove that line. This line caused a limited impact where if some (many?) of the docker containers were already built, except for dhcp-relay, and the build failed or was interrupted, then dhcp-relay container would fail to build because this variable was overwritten and the python3-swsscommon wouldn't get installed into the slave container. Most builds would be fine, though. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dhcp6relay rules file had a line overwriting a variable for
docker-dhcp-relay. Remove that line.
This line caused a limited impact where if some (many?) of the docker
containers were already built, except for dhcp-relay, and the build
failed or was interrupted, then dhcp-relay container would fail to build
because this variable was overwritten and the python3-swsscommon
wouldn't get installed into the slave container. Most builds would be
fine, though.
Signed-off-by: Saikrishna Arcot sarcot@microsoft.com
Why I did it
How I did it
How to verify it
To see the failure:
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)