Added get_system_mac support for cisco-8000 device#9104
Merged
abdosi merged 2 commits intosonic-net:masterfrom Nov 4, 2021
anamehra:anamehra/get_system_mac
Merged
Added get_system_mac support for cisco-8000 device#9104abdosi merged 2 commits intosonic-net:masterfrom anamehra:anamehra/get_system_mac
abdosi merged 2 commits intosonic-net:masterfrom
anamehra:anamehra/get_system_mac
Conversation
Signed-off-by: anamehra <anamehra@cisco.com>
Contributor
Author
|
cc @abdosi |
abdosi
reviewed
Oct 28, 2021
src/sonic-config-engine/minigraph.py
Outdated
| for child in root: | ||
| if child.tag == str(QName(ns, "MetadataDeclaration")): | ||
| _, _, switch_type, _ = parse_asic_meta(child, asic_name) | ||
| return switch_type |
Contributor
There was a problem hiding this comment.
can we handle failure case of return None when the if condition fails.
abdosi
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: anamehra anamehra@cisco.com
Why I did it
This is required to assign unique MACs to namespaces on Backend and Frontend asics
for cisco-8000 platforms
How I did it
Add vendor specific hook in get_system_mac. The MAC address are read from /profile.ini
file
How to verify it
config load_minigraph on a multi-asic system
config save
check mac addresses in DEVICE_METADATA section in each config_db json file
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)