[docker-sonic-vs]Added support for Mellanox-SN2700 based SKU for docker-sonic-vs#9044
[docker-sonic-vs]Added support for Mellanox-SN2700 based SKU for docker-sonic-vs#9044lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
|
can you explain the motivation for doing this? |
To have docker-sonic-vs Mellanox-SN2700 based docker-sonic-vs SKU functional. Currently It is missing few files. Additionally there were some concerns over using fake_platform by @kcudnik |
|
@lguohan Updated the description. Let me know if this sounds good. |
… used (#9175) *Removing fake_platform environment variable. Following the merge of #9044 and sonic-net/sonic-swss#1978 the fake_platform environment variable is not used in any place and removing the stale references. Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
Why I did it
Added support for Mellanox-SN2700 based SKU for docker-sonic-vs and to differentiate platform based on hw-sku rather than on fake_platform in VS.
Currently SAI VS library uses hwsku based SAI profile to differentiate and mock different platform implementations. The same functionality in swss is achieved using a fake_platform env variable.
Using a fake_platform has some drawbacks that the vs container appears to still use a different vendor hw-sku
In order to unify the approach at both swss and vs SAI and to be uniform throughout this PR introduces the approach of using hw-sku to differentiate different platforms. This requires support for Mellanox-SN2700 HWSKU for Mellanox platform which is also addressed by this PR.
How I did it
Copied relevant platform files. Modified orchagent scripts to infer platform from hwsku.
How to verify it
Run the tests that depend on platform type in vs and ensure they pass using the new approach.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)