[build] Use pip to install setup.py dependency instead of python setup.py install

[qiluo-msft]

Why I did it

Fix a recent build error introduced by a pre-release redis-py. This is a general issue because python setup.py install (ie easy_instal) does not ignore pre-release versions. The fix is suggested by pypa/setuptools#855 (comment)

[ building ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ] 
Applying patch ../redis-dump-load.patch/0001-Use-pipelines-when-dumping-52.patch
patching file redisdl.py

Applying patch ../redis-dump-load.patch/0002-Fix-setup.py-for-test-and-bdist_wheel.patch
patching file setup.py

Now at patch ../redis-dump-load.patch/0002-Fix-setup.py-for-test-and-bdist_wheel.patch
[ finished ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ] 
[ FAIL LOG START ] [ target/python-wheels/redis_dump_load-1.1-py2-none-any.whl ]
[ REASON ] :      target/python-wheels/redis_dump_load-1.1-py2-none-any.whl does not exist  
[ FLAGS  FILE    ] : [] 
[ FLAGS  DEPENDS ] : [broadcom] 
[ FLAGS  DIFF    ] : [broadcom ] 
/sonic/src/redis-dump-load /sonic
running test
Searching for redis
Reading https://pypi.org/simple/redis/
Downloading https://files.pythonhosted.org/packages/62/ab/6491b41bbfb938afbc4424164983d1def3c59434c77e8cf710213be03fed/redis-4.0.0b1.tar.gz#sha256=f778e27d542ba1f43a6b02a80fa904d8a49e5d3b824ec5fb3f0d5cbdba11e4cd
Best match: redis 4.0.0b1
Processing redis-4.0.0b1.tar.gz
Writing /tmp/easy_install-ZCmBMQ/redis-4.0.0b1/setup.cfg
Running redis-4.0.0b1/setup.py -q bdist_egg --dist-dir /tmp/easy_install-ZCmBMQ/redis-4.0.0b1/egg-dist-tmp-QcQyOe
Traceback (most recent call last):
  File "setup.py", line 41, in <module>
    'Topic :: System :: Archiving',
  File "/usr/lib/python2.7/dist-packages/setuptools/__init__.py", line 145, in setup
    return distutils.core.setup(**attrs)
  File "/usr/lib/python2.7/distutils/core.py", line 151, in setup
    dist.run_commands()
  File "/usr/lib/python2.7/distutils/dist.py", line 953, in run_commands
    self.run_command(cmd)

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

[xumia]

@qiluo-msft , we need to add the labels, right?

[fastiuk]

In my opinion, it is better to restrict the required version of redis of redis-dump-load module.
It will eliminate all future problems.
src/redis-dump-load/requirements.txt:

diff --git a/requirements.txt b/requirements.txt
index 7800f0f..3fc0632 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1 +1 @@
-redis
+redis==3.5.3

[MalteJ]

The problem is that redis client v4 will drop support for Python2 (see redis/redis-py#1318)
So there are two things we should do:

1. Pin the redis client to version 3.5.3 as described by @fastiuk
2. Remove Python 2 completely from SONiC

[qiluo-msft]

@saiarcot895 I revert your fix and redo the fix. Could you please help review?

[saiarcot895]

Does pip read the requirements.txt file by default for getting the list of packages to install?

[qiluo-msft]

What you mentioned is pip -r requirements.txt. And pip install . is checking the setup.py for dependencies, install them and also the package itself.