[YANG][DPB] Added regex with no 40G mode#8958
Closed
vadymhlushko-mlnx wants to merge 1 commit intosonic-net:masterfrom
Closed
[YANG][DPB] Added regex with no 40G mode#8958vadymhlushko-mlnx wants to merge 1 commit intosonic-net:masterfrom
vadymhlushko-mlnx wants to merge 1 commit intosonic-net:masterfrom
Conversation
…out modes Signed-off-by: Vadym Hlushko <[email protected]>
Collaborator
|
@praveen-li can you please review? |
praveen-li
reviewed
Oct 18, 2021
| * Breakout to that breakout-mode. | ||
| */ | ||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]'; | ||
| pattern '1x100G\[40G\]|2x50G|4x25G\[10G\]|2x25G\(2\)\+1x50G\(2\)|1x50G\(2\)\+2x25G\(2\)|1x400G|2x200G|4x100G|8x50G|1x200G\[100G,50G,40G,25G,10G,1G\]|2x100G\[50G,40G,25G,10G,1G\]|4x50G\[40G,25G,10G,1G\]|1x25G\[10G\]|1x100G\[50G,40G,25G,10G\]|2x50G\[40G,25G,10G\]|4x25G\[10G\]|1x25G\[10G,1G\]|1x100G\[50G,40G,25G,10G,1G\]|2x50G\[25G,10G,1G\]|2x50G\[25G,10G\]|2x50G\[40G,25G,10G,1G\]|4x25G\[10G,1G\]|1x400G\[200G,100G,50G,40G,25G,10G,1G\]|2x200G\[100G,50G,40G,25G,10G,1G\]|4x100G\[50G,40G,25G,10G,1G\]'; |
Member
There was a problem hiding this comment.
We are removing this pattern under other PR, so this PR will become not applicable. Thx.
Collaborator
There was a problem hiding this comment.
Can you please refer to the other PR?
As this issue is also needed for 202106 we should have the fix soon.
Contributor
Author
There was a problem hiding this comment.
We are removing this pattern under other PR, so this PR will become not applicable. Thx.
@praveen-li could you please provide a link to other PR?
vadymhlushko-mlnx
changed the title
Member
Collaborator
|
Thanks @praveen-li for sharing the PR #6801. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vadym Hlushko [email protected]
Why I did it
Fix for the issue caused by - pull/8712).
For some platforms was removed
40Gspeed mode, but the regex for Dynamic Port breakout modes validation remains the same.How I did it
Added new regex for -
2x50G[25G,10G]and2x50G[25G,10G,1G]breakout modesHow to verify it
Extended existing test case with new values.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)